Bug 109433

Summary: Web Inspector: WebInspector.Project refactorings.
Product: WebKit Reporter: Vsevolod Vlasov <vsevik>
Component: Web Inspector (Deprecated)Assignee: Vsevolod Vlasov <vsevik>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, keishi, loislo, pfeldman, pmuellr, vsevik, web-inspector-bugs, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch apavlov: review+, apavlov: commit-queue-

Description Vsevolod Vlasov 2013-02-11 07:15:38 PST 
This change prepares Workspace and Project to migration to project-per-domain mode for network based projects.
Renamed WebInspector.WorkspaceProvider to WebInspector.ProjectDelegate.
Renamed Project.name() to Project.id() and delegated it to project delegate.
Added Project.displayName() method that is delegated to project delegate..
SimpleWorkspaceProvider is now responsible for creation of SimpleWorkspaceDelegates and isolates various mappings from Project/ProjectDelegate concept.
UISourceCode is now created based on path in the project.
UISourceCode uri is now calculated based on project and path (right now uri is equal to path).
Comment 1 Vsevolod Vlasov 2013-02-11 07:19:21 PST 
Created attachment 187568 [details]
Patch
Comment 2 Alexander Pavlov (apavlov) 2013-02-11 07:35:13 PST 
Comment on attachment 187568 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=187568&action=review

> Source/WebCore/ChangeLog:11
> +        Added Project.displayName() method that is delegated to project delegate..

Duplicate trailing .

> Source/WebCore/inspector/front-end/UISourceCode.js:106
> +        return this._path; 

Trailing whitespace

> Source/WebCore/inspector/front-end/Workspace.js:166
> +    type: function() 

Trailing whitespace

> Source/WebCore/inspector/front-end/Workspace.js:223
> +        return this._uiSourceCodes[path];

return ... || null; for the @return type conformance.
Comment 3 Vsevolod Vlasov 2013-02-11 07:52:25 PST 
Committed r142474: <http://trac.webkit.org/changeset/142474>