Bug 109432

Summary: Web Inspector: fix closure compiler warnings in the profiler code
Product: WebKit Reporter: Yury Semikhatsky <yurys>
Component: Web Inspector (Deprecated)Assignee: Yury Semikhatsky <yurys>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, keishi, loislo, pfeldman, pmuellr, vsevik, web-inspector-bugs, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Description Yury Semikhatsky 2013-02-11 07:15:24 PST
Source/WebCore/inspector/front-end/NativeMemorySnapshotView.js:500: WARNING - parameter graph does not appear in didReceiveMemorySnapshot's parameter list
        function didReceiveMemorySnapshot(error, memoryBlock)
        ^

Source/WebCore/inspector/front-end/NativeMemorySnapshotView.js:678: WARNING - parameter graph does not appear in didReceiveMemorySnapshot's parameter list
        function didReceiveMemorySnapshot(error, memoryBlock)
        ^

Source/WebCore/inspector/front-end/ProfilesPanel.js:1249: WARNING - mismatch of the addNativeSnapshotChunk property type and the type of the property it overrides from interface MemoryAgent.Dispatcher
original: function (this:MemoryAgent.Dispatcher, (null|{baseToRealNodeId: (Array.<number>|null), edges: (Array.<number>|null), nodes: (Array.<number>|null), strings: (Array.<string>|null), ...})): undefined
override: function (this:WebInspector.MemoryDispatcher, string): undefined
    addNativeSnapshotChunk: function(chunk)
    ^

Source/WebCore/inspector/front-end/ProfilesPanel.js:1249: WARNING - parameter uid does not appear in WebInspector.MemoryDispatcher.prototype.addNativeSnapshotChunk's parameter list
    addNativeSnapshotChunk: function(chunk)
                            ^
Comment 1 Yury Semikhatsky 2013-02-11 07:16:41 PST
Created attachment 187567 [details]
Patch
Comment 2 WebKit Review Bot 2013-02-11 07:47:25 PST
Comment on attachment 187567 [details]
Patch

Clearing flags on attachment: 187567

Committed r142473: <http://trac.webkit.org/changeset/142473>
Comment 3 WebKit Review Bot 2013-02-11 07:47:28 PST
All reviewed patches have been landed.  Closing bug.