Bug 109430

Summary: Web Inspector: separate SuggestBox from TextPrompt
Product: WebKit Reporter: Andrey Lushnikov <lushnikov>
Component: Web Inspector (Deprecated)Assignee: Andrey Lushnikov <lushnikov>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, keishi, loislo, pfeldman, pmuellr, vsevik, web-inspector-bugs, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Description Andrey Lushnikov 2013-02-11 07:07:29 PST 
Separate SuggestBox implementation from TextPrompt by the means of intermediate interface.
Comment 1 Andrey Lushnikov 2013-02-12 02:35:41 PST 
Created attachment 187816 [details]
Patch
Comment 2 Alexander Pavlov (apavlov) 2013-02-12 04:05:24 PST 
Comment on attachment 187816 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=187816&action=review

> Source/WebCore/inspector/front-end/TextPrompt.js:950
> +WebInspector.TextPrompt.SuggestBoxDelegate = function ()

extra whitespace before "()"

> Source/WebCore/inspector/front-end/TextPrompt.js:954
> +WebInspector.TextPrompt.SuggestBoxDelegate.prototype = {

This should rather be WebInspector.SuggestBoxDelegate, next to WebInspector.SuggestBox

> Source/WebCore/inspector/front-end/TextPrompt.js:975
> +WebInspector.TextPrompt.SuggestBox = function(suggestBoxDelegate, inputElement, className)

This should become WebInspector.SuggestBox, preferably in its own file
Comment 3 Andrey Lushnikov 2013-02-12 04:29:51 PST 
Created attachment 187831 [details]
Patch
Comment 4 Andrey Lushnikov 2013-02-12 05:01:32 PST 
Created attachment 187836 [details]
Patch
Comment 5 Andrey Lushnikov 2013-02-12 05:28:18 PST 
Created attachment 187841 [details]
Patch
Comment 6 WebKit Review Bot 2013-02-12 06:05:47 PST 
Comment on attachment 187841 [details]
Patch

Clearing flags on attachment: 187841

Committed r142610: <http://trac.webkit.org/changeset/142610>
Comment 7 WebKit Review Bot 2013-02-12 06:05:52 PST 
All reviewed patches have been landed.  Closing bug.