Summary: | Make WebVTTTokenizer stop inheriting from MarkupTokenizerBase | ||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Eric Seidel (no email) <eric> | ||||||||||||||
Component: | New Bugs | Assignee: | Eric Seidel (no email) <eric> | ||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||
Severity: | Normal | CC: | abarth, dglazkov, dgorbik, eric.carlson, gtk-ews, ojan.autocc, tonyg, webkit.review.bot, xan.lopez | ||||||||||||||
Priority: | P2 | ||||||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||||
Hardware: | Unspecified | ||||||||||||||||
OS: | Unspecified | ||||||||||||||||
Bug Depends on: | |||||||||||||||||
Bug Blocks: | 107522 | ||||||||||||||||
Attachments: |
|
Description
Eric Seidel (no email)
2013-02-11 02:11:04 PST
Created attachment 187529 [details]
Patch
Created attachment 187609 [details]
Patch
Created attachment 187612 [details]
Patch
Comment on attachment 187612 [details] Patch Attachment 187612 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/16493297 Comment on attachment 187612 [details] Patch Attachment 187612 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/16491307 Sigh. I was too tricky for some compilers. Will fix. Comment on attachment 187612 [details]
Patch
Need to fix compilation. Else looks good.
Comment on attachment 187612 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=187612&action=review > Source/WebCore/html/parser/InputStreamPreprocessor.h:84 > + if (m_tokenizer->shouldSkipNullCharacters()) { Another option is to pass this bit in to peek rather than keeping a pointer to the tokenizer. That would let your remove the template parameter. Maybe in a followup patch? Comment on attachment 187612 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=187612&action=review >> Source/WebCore/html/parser/InputStreamPreprocessor.h:84 >> + if (m_tokenizer->shouldSkipNullCharacters()) { > > Another option is to pass this bit in to peek rather than keeping a pointer to the tokenizer. That would let your remove the template parameter. Maybe in a followup patch? Yup. This function is ridiculously hot, so I didn't want to add that overhead to every callsite in the chnace that it changed perf. We can try it in a separate patch. Created attachment 187623 [details]
Patch
Comment on attachment 187623 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=187623&action=review > Source/WebCore/html/parser/HTMLInputStream.h:40 > +// The current segmented string is stored in InputStream. Each of afterInsertionPoint Sublime got me. Fixed. Created attachment 187625 [details]
Patch
Comment on attachment 187625 [details] Patch Attachment 187625 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/16448060 Created attachment 187637 [details]
Patch
Comment on attachment 187637 [details] Patch Clearing flags on attachment: 187637 Committed r142497: <http://trac.webkit.org/changeset/142497> All reviewed patches have been landed. Closing bug. |