Bug 109403

Summary: [chromium] Add WebUnitTestSupport::createLayerTreeViewForTesting for webkit_unit_tests
Product: WebKit Reporter: James Robinson <jamesr>
Component: New BugsAssignee: James Robinson <jamesr>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dglazkov, enne, fishd, jamesr, peter+ews, tkent+wkapi, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 109541    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch none

Description James Robinson 2013-02-11 00:01:33 PST
[chromium] Add WebUnitTestSupport::createLayerTreeViewForTesting for webkit_unit_tests
Comment 1 James Robinson 2013-02-11 00:02:48 PST
Created attachment 187517 [details]
Patch
Comment 2 James Robinson 2013-02-11 00:03:22 PST
Chromium side implementation is here: https://codereview.chromium.org/12211110/

Before that lands, this patch will compile but GraphicsLayerChromiumTest and ScrollingCoordinatorChromiumTest will fail.
Comment 3 WebKit Review Bot 2013-02-11 00:20:34 PST
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 4 WebKit Review Bot 2013-02-11 00:51:50 PST
Comment on attachment 187517 [details]
Patch

Attachment 187517 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/16491129
Comment 5 WebKit Review Bot 2013-02-11 00:57:17 PST
Comment on attachment 187517 [details]
Patch

Attachment 187517 [details] did not pass cr-linux-debug-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/16498088
Comment 6 Peter Beverloo (cr-android ews) 2013-02-11 01:10:06 PST
Comment on attachment 187517 [details]
Patch

Attachment 187517 [details] did not pass cr-android-ews (chromium-android):
Output: http://queues.webkit.org/results/16493112
Comment 7 James Robinson 2013-02-11 15:23:42 PST
Created attachment 187694 [details]
Patch
Comment 8 James Robinson 2013-02-11 15:26:40 PST
The second patch adds a type enum.  I want to use to this to provide compositing support to DumpRenderTree as well.
Comment 9 WebKit Review Bot 2013-02-11 15:56:58 PST
Comment on attachment 187694 [details]
Patch

Attachment 187694 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/16497421
Comment 10 Peter Beverloo (cr-android ews) 2013-02-11 16:17:18 PST
Comment on attachment 187694 [details]
Patch

Attachment 187694 [details] did not pass cr-android-ews (chromium-android):
Output: http://queues.webkit.org/results/16485624
Comment 11 WebKit Review Bot 2013-02-11 17:02:23 PST
Comment on attachment 187694 [details]
Patch

Attachment 187694 [details] did not pass cr-linux-debug-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/16493491
Comment 12 Adam Barth 2013-02-11 17:15:20 PST
Comment on attachment 187694 [details]
Patch

Ok.  You've got some red bots to work through.
Comment 13 James Robinson 2013-02-11 18:52:30 PST
Comment on attachment 187694 [details]
Patch

Clearing flags on attachment: 187694

Committed r142568: <http://trac.webkit.org/changeset/142568>
Comment 14 James Robinson 2013-02-11 18:52:34 PST
All reviewed patches have been landed.  Closing bug.
Comment 15 WebKit Review Bot 2013-02-11 20:13:59 PST
Re-opened since this is blocked by bug 109541
Comment 16 James Robinson 2013-02-11 22:12:16 PST
(In reply to comment #15)
> Re-opened since this is blocked by bug 109541

ASSERT_TRUE expands to a return statement, which doesn't work in a constructor.  Not sure how this compiles sometimes.
Comment 17 James Robinson 2013-02-11 22:45:01 PST
Committed r142581: <http://trac.webkit.org/changeset/142581>