Summary: | [chromium] Add WebUnitTestSupport::createLayerTreeViewForTesting for webkit_unit_tests | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | James Robinson <jamesr> | ||||||
Component: | New Bugs | Assignee: | James Robinson <jamesr> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | abarth, dglazkov, enne, fishd, jamesr, peter+ews, tkent+wkapi, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | 109541 | ||||||||
Bug Blocks: | |||||||||
Attachments: |
|
Description
James Robinson
2013-02-11 00:01:33 PST
Created attachment 187517 [details]
Patch
Chromium side implementation is here: https://codereview.chromium.org/12211110/ Before that lands, this patch will compile but GraphicsLayerChromiumTest and ScrollingCoordinatorChromiumTest will fail. Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI. Comment on attachment 187517 [details] Patch Attachment 187517 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/16491129 Comment on attachment 187517 [details] Patch Attachment 187517 [details] did not pass cr-linux-debug-ews (chromium-xvfb): Output: http://queues.webkit.org/results/16498088 Comment on attachment 187517 [details] Patch Attachment 187517 [details] did not pass cr-android-ews (chromium-android): Output: http://queues.webkit.org/results/16493112 Created attachment 187694 [details]
Patch
The second patch adds a type enum. I want to use to this to provide compositing support to DumpRenderTree as well. Comment on attachment 187694 [details] Patch Attachment 187694 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/16497421 Comment on attachment 187694 [details] Patch Attachment 187694 [details] did not pass cr-android-ews (chromium-android): Output: http://queues.webkit.org/results/16485624 Comment on attachment 187694 [details] Patch Attachment 187694 [details] did not pass cr-linux-debug-ews (chromium-xvfb): Output: http://queues.webkit.org/results/16493491 Comment on attachment 187694 [details]
Patch
Ok. You've got some red bots to work through.
Comment on attachment 187694 [details] Patch Clearing flags on attachment: 187694 Committed r142568: <http://trac.webkit.org/changeset/142568> All reviewed patches have been landed. Closing bug. Re-opened since this is blocked by bug 109541 (In reply to comment #15) > Re-opened since this is blocked by bug 109541 ASSERT_TRUE expands to a return statement, which doesn't work in a constructor. Not sure how this compiles sometimes. Committed r142581: <http://trac.webkit.org/changeset/142581> |