Bug 109381

Summary: WKTR should propagate view creation options to opened windows
Product: WebKit Reporter: Tim Horton <thorton>
Component: Tools / TestsAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch simon.fraser: review+

Tim Horton
Reported 2013-02-10 11:18:15 PST
The options dictionary is dropped on the floor for window.open'd windows, but it would be nice if it weren't.
Attachments
patch (5.33 KB, patch)
2013-02-10 11:21 PST, Tim Horton 		simon.fraser: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2013-02-10 11:21:45 PST
Created attachment 187487 [details] patch
Simon Fraser (smfr)
Comment 2 2013-02-10 11:24:28 PST
Comment on attachment 187487 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=187487&action=review > Tools/ChangeLog:3 > + WKTR should propagate view creation options to subviews ''to subviews isn't quite accurate. "to opened windows"?
Tim Horton
Comment 3 2013-02-10 11:25:42 PST
Yeah, it's a bit weird. I've been flopping between calling them subviews and subwindows :| It's really "to PlatformWebViews in subwindows". I'll go with "to opened windows". Thanks!
Tim Horton
Comment 4 2013-02-10 11:29:09 PST
http://trac.webkit.org/changeset/142412
Note You need to log in before you can comment on or make changes to this bug.