Summary: | [WK2][EFL] Cleanup of graphics related code in EwkView | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Kenneth Rohde Christiansen <kenneth> | ||||||||||
Component: | WebKit2 | Assignee: | Kenneth Rohde Christiansen <kenneth> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | andersca, benjamin, buildbot, cdumez, gyuyoung.kim, mikhail.pozdnyakov, rakuco, rniwa, tmpsantos, webkit.review.bot | ||||||||||
Priority: | P2 | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Attachments: |
|
Description
Kenneth Rohde Christiansen
2013-02-10 05:51:58 PST
Created attachment 187479 [details]
Work in progress
Created attachment 187591 [details]
Patch
Comment on attachment 187591 [details] Patch Attachment 187591 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://queues.webkit.org/results/16496563 New failing tests: http/tests/cache/cached-main-resource.html (In reply to comment #3) > (From update of attachment 187591 [details]) > Attachment 187591 [details] did not pass mac-wk2-ews (mac-wk2): > Output: http://queues.webkit.org/results/16496563 > > New failing tests: > http/tests/cache/cached-main-resource.html Unrelated Comment on attachment 187591 [details]
Patch
LGTM.
Created attachment 187872 [details]
Patch
Comment on attachment 187872 [details]
Patch
looks nice
Comment on attachment 187872 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=187872&action=review Looks nice too. > Source/WebKit2/UIProcess/API/efl/EwkView.h:80 > +class TransformationMatrix; Wrong alphabet order ? Comment on attachment 187872 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=187872&action=review >> Source/WebKit2/UIProcess/API/efl/EwkView.h:80 >> +class TransformationMatrix; > > Wrong alphabet order ? Yup, please fix. Created attachment 188092 [details]
Patch for landing
Comment on attachment 188092 [details] Patch for landing Clearing flags on attachment: 188092 Committed r142758: <http://trac.webkit.org/changeset/142758> All reviewed patches have been landed. Closing bug. It looks like this patch may have caused 2 regressions on the bots: http://build.webkit.org/results/EFL%20Linux%2064-bit%20Debug%20WK2/r142759%20(9446)/results.html In particular: http://build.webkit.org/results/EFL%20Linux%2064-bit%20Debug%20WK2/r142759%20(9446)/fast/dom/Window/mozilla-focus-blur-pretty-diff.html http://build.webkit.org/results/EFL%20Linux%2064-bit%20Debug%20WK2/r142759%20(9446)/compositing/layer-creation/fixed-position-out-of-view-scaled-crash-log.txt |