Bug 109377

Summary: [WK2][EFL] Cleanup of graphics related code in EwkView
Product: WebKit Reporter: Kenneth Rohde Christiansen <kenneth>
Component: WebKit2Assignee: Kenneth Rohde Christiansen <kenneth>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, benjamin, buildbot, cdumez, gyuyoung.kim, mikhail.pozdnyakov, rakuco, rniwa, tmpsantos, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Work in progress
none
Patch
none
Patch
none
Patch for landing none

Description Kenneth Rohde Christiansen 2013-02-10 05:51:58 PST
SSIA.
Comment 1 Kenneth Rohde Christiansen 2013-02-10 05:55:50 PST
Created attachment 187479 [details]
Work in progress
Comment 2 Kenneth Rohde Christiansen 2013-02-11 08:53:39 PST
Created attachment 187591 [details]
Patch
Comment 3 Build Bot 2013-02-11 20:04:50 PST
Comment on attachment 187591 [details]
Patch

Attachment 187591 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://queues.webkit.org/results/16496563

New failing tests:
http/tests/cache/cached-main-resource.html
Comment 4 Kenneth Rohde Christiansen 2013-02-12 05:25:27 PST
(In reply to comment #3)
> (From update of attachment 187591 [details])
> Attachment 187591 [details] did not pass mac-wk2-ews (mac-wk2):
> Output: http://queues.webkit.org/results/16496563
> 
> New failing tests:
> http/tests/cache/cached-main-resource.html

Unrelated
Comment 5 Chris Dumez 2013-02-12 05:35:17 PST
Comment on attachment 187591 [details]
Patch

LGTM.
Comment 6 Kenneth Rohde Christiansen 2013-02-12 08:26:05 PST
Created attachment 187872 [details]
Patch
Comment 7 Mikhail Pozdnyakov 2013-02-12 08:33:47 PST
Comment on attachment 187872 [details]
Patch

looks nice
Comment 8 Gyuyoung Kim 2013-02-12 17:56:20 PST
Comment on attachment 187872 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=187872&action=review

Looks nice too.

> Source/WebKit2/UIProcess/API/efl/EwkView.h:80
> +class TransformationMatrix;

Wrong alphabet order ?
Comment 9 Anders Carlsson 2013-02-13 08:49:29 PST
Comment on attachment 187872 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=187872&action=review

>> Source/WebKit2/UIProcess/API/efl/EwkView.h:80
>> +class TransformationMatrix;
> 
> Wrong alphabet order ?

Yup, please fix.
Comment 10 Kenneth Rohde Christiansen 2013-02-13 09:00:09 PST
Created attachment 188092 [details]
Patch for landing
Comment 11 WebKit Review Bot 2013-02-13 09:48:11 PST
Comment on attachment 188092 [details]
Patch for landing

Clearing flags on attachment: 188092

Committed r142758: <http://trac.webkit.org/changeset/142758>
Comment 12 WebKit Review Bot 2013-02-13 09:48:16 PST
All reviewed patches have been landed.  Closing bug.