| Summary: | [chromium] Fix Android scrollbar size | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alexandre Elias <aelias> | ||||||||
| Component: | New Bugs | Assignee: | Alexandre Elias <aelias> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | aelias, dglazkov, jamesr, peter+ews, trchen, webkit.review.bot | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Alexandre Elias
2013-02-10 01:04:47 PST
Created attachment 187469 [details]
Patch
Comment on attachment 187469 [details] Patch Attachment 187469 [details] did not pass cr-android-ews (chromium-android): Output: http://queues.webkit.org/results/16468789 Comment on attachment 187469 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=187469&action=review > Source/WebCore/platform/chromium/ScrollbarThemeChromiumAndroid.cpp:114 > + context->fillRect(centerRect, Color(128, 128, 128, 128), ColorSpaceDeviceRGB); as EWS points out, this doesn't compile. What did you mean here instead of centerRect? thumbRect ? Comment on attachment 187469 [details]
Patch
Could you just extend the thumb rect out very slightly to get some edge AA?
R=me if you make it compile
Created attachment 187502 [details]
Patch
Fix compile error (centerRect->thumbRect)
Created attachment 187503 [details]
Patch for landing
Just saw your edge AA comment. Tien-Ren is reimplementing this to use SolidColorQuad (since scrollbar texture management is proving a pain) so let's revisit there. Comment on attachment 187503 [details] Patch for landing Clearing flags on attachment: 187503 Committed r142423: <http://trac.webkit.org/changeset/142423> All reviewed patches have been landed. Closing bug. |