Bug 109349

Summary: Kill TestRunner::setMinimumTimerInterval; implement the feature with InternalSettings
Product: WebKit Reporter: Benjamin Poulain <benjamin>
Component: New BugsAssignee: Benjamin Poulain <benjamin>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dglazkov, fishd, gtk-ews, gyuyoung.kim, jamesr, jochen, mifenton, philn, rakuco, roger_fong, rwlbuis, tkent+wkapi, tonikitoo, webkit.review.bot, xan.lopez, yong.li.webkit
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Benjamin Poulain 2013-02-08 22:14:14 PST 
Kill TestRunner::setMinimumTimerInterval; implement the feature with InternalSettings
Comment 1 Benjamin Poulain 2013-02-08 22:23:09 PST 
Created attachment 187415 [details]
Patch
Comment 2 WebKit Review Bot 2013-02-08 22:25:57 PST 
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 3 Benjamin Poulain 2013-02-08 22:37:50 PST 
Created attachment 187417 [details]
Patch
Comment 4 James Robinson 2013-02-08 22:57:13 PST 
Comment on attachment 187417 [details]
Patch

Would r+ but I'm not allowed since this touches WebKit2
Comment 5 kov's GTK+ EWS bot 2013-02-08 23:08:11 PST 
Comment on attachment 187417 [details]
Patch

Attachment 187417 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/16478072
Comment 6 Benjamin Poulain 2013-02-08 23:22:54 PST 
> (From update of attachment 187417 [details])
> Would r+ but I'm not allowed since this touches WebKit2

No problem. Thank for checking the Chromium changes are okay.
Comment 7 Benjamin Poulain 2013-02-10 13:27:52 PST 
Created attachment 187493 [details]
Patch
Comment 8 Benjamin Poulain 2013-02-11 13:42:33 PST 
Comment on attachment 187493 [details]
Patch

Clearing flags on attachment: 187493

Committed r142509: <http://trac.webkit.org/changeset/142509>
Comment 9 Benjamin Poulain 2013-02-11 13:42:37 PST 
All reviewed patches have been landed.  Closing bug.
Comment 10 Roger Fong 2013-02-11 14:36:48 PST 
I believe this broke the Windows build here: 
http://build.webkit.org/builders/Apple%20Win%20Debug%20%28Build%29/builds/62268/steps/compile-webkit/logs/stdio
Comment 11 Benjamin Poulain 2013-02-11 14:40:23 PST 
(In reply to comment #10)
> I believe this broke the Windows build here: 
> http://build.webkit.org/builders/Apple%20Win%20Debug%20%28Build%29/builds/62268/steps/compile-webkit/logs/stdio

I'll update the symbols. The bot was not working previously.
Comment 12 Benjamin Poulain 2013-02-11 14:52:48 PST 
Windows symbols in http://trac.webkit.org/changeset/142519