Bug 109334

Summary:

Harden FastMalloc (again)

Product:

WebKit

Reporter:

Oliver Hunt <oliver>

Component:

New Bugs

Assignee:

Oliver Hunt <oliver>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

benjamin, cmarcelo, ojan.autocc, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

121307

Attachments:

Description	Flags
Patch	none
Patch	mhahnenberg: review+

Oliver Hunt

Reported 2013-02-08 16:48:30 PST

Harden FastMalloc (again)

Attachments
Patch (48.67 KB, patch) 2013-02-08 16:57 PST, Oliver Hunt	no flags	Details Formatted Diff Diff
Patch (48.80 KB, patch) 2013-02-11 15:16 PST, Oliver Hunt	mhahnenberg: review+	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Oliver Hunt

Comment 1 2013-02-08 16:57:15 PST

Created attachment 187388 [details] Patch

WebKit Review Bot

Comment 2 2013-02-08 17:06:06 PST

Attachment 187388 [details] did not pass style-queue: Source/WTF/wtf/FastMalloc.cpp:547: Place brace on its own line for function definitions. [whitespace/braces] [4] Source/WTF/wtf/FastMalloc.cpp:695: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] Source/WTF/wtf/FastMalloc.cpp:727: One space before end of line comments [whitespace/comments] [5] Source/WTF/wtf/FastMalloc.cpp:727: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:728: One space before end of line comments [whitespace/comments] [5] Source/WTF/wtf/FastMalloc.cpp:728: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:754: Place brace on its own line for function definitions. [whitespace/braces] [4] Source/WTF/wtf/FastMalloc.cpp:754: SLL_Next is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WTF/wtf/FastMalloc.cpp:758: Place brace on its own line for function definitions. [whitespace/braces] [4] Source/WTF/wtf/FastMalloc.cpp:758: SLL_SetNext is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WTF/wtf/FastMalloc.cpp:762: Place brace on its own line for function definitions. [whitespace/braces] [4] Source/WTF/wtf/FastMalloc.cpp:762: SLL_Push is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WTF/wtf/FastMalloc.cpp:763: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:767: Place brace on its own line for function definitions. [whitespace/braces] [4] Source/WTF/wtf/FastMalloc.cpp:767: SLL_Pop is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WTF/wtf/FastMalloc.cpp:768: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:769: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:778: Place brace on its own line for function definitions. [whitespace/braces] [4] Source/WTF/wtf/FastMalloc.cpp:778: SLL_PopRange is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WTF/wtf/FastMalloc.cpp:785: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:792: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:794: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:797: Place brace on its own line for function definitions. [whitespace/braces] [4] Source/WTF/wtf/FastMalloc.cpp:797: SLL_PushRange is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WTF/wtf/FastMalloc.cpp:799: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:803: Place brace on its own line for function definitions. [whitespace/braces] [4] Source/WTF/wtf/FastMalloc.cpp:803: SLL_Size is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WTF/wtf/FastMalloc.cpp:1001: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1001: allocated_regions_ is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WTF/wtf/FastMalloc.cpp:1004: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1004: free_list_ is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WTF/wtf/FastMalloc.cpp:1008: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1008: entropy_ is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WTF/wtf/FastMalloc.cpp:1011: Place brace on its own line for function definitions. [whitespace/braces] [4] Source/WTF/wtf/FastMalloc.cpp:1011: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1017: Use 0 instead of NULL. [readability/null] [5] Source/WTF/wtf/FastMalloc.cpp:1025: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1026: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1034: _head is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WTF/wtf/FastMalloc.cpp:1049: _head is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WTF/wtf/FastMalloc.cpp:1061: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1062: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1103: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1104: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1105: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1106: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1107: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1113: One space before end of line comments [whitespace/comments] [5] Source/WTF/wtf/FastMalloc.cpp:1113: Extra space between HardenedSLL and objects [whitespace/declaration] [3] Source/WTF/wtf/FastMalloc.cpp:1113: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1169: Place brace on its own line for function definitions. [whitespace/braces] [4] Source/WTF/wtf/FastMalloc.cpp:1169: DLL_Init is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WTF/wtf/FastMalloc.cpp:1170: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1171: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1174: Place brace on its own line for function definitions. [whitespace/braces] [4] Source/WTF/wtf/FastMalloc.cpp:1174: DLL_Remove is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WTF/wtf/FastMalloc.cpp:1175: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1176: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1177: Use 0 instead of NULL. [readability/null] [5] Source/WTF/wtf/FastMalloc.cpp:1177: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1178: Use 0 instead of NULL. [readability/null] [5] Source/WTF/wtf/FastMalloc.cpp:1178: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1181: Place brace on its own line for function definitions. [whitespace/braces] [4] Source/WTF/wtf/FastMalloc.cpp:1182: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1185: Place brace on its own line for function definitions. [whitespace/braces] [4] Source/WTF/wtf/FastMalloc.cpp:1185: DLL_Length is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WTF/wtf/FastMalloc.cpp:1187: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1203: Place brace on its own line for function definitions. [whitespace/braces] [4] Source/WTF/wtf/FastMalloc.cpp:1203: DLL_Prepend is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WTF/wtf/FastMalloc.cpp:1204: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1205: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1206: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1207: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1216: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1222: The parameter name "N" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WTF/wtf/FastMalloc.cpp:1222: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1225: The parameter name "N" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WTF/wtf/FastMalloc.cpp:1225: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1244: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1245: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1246: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1247: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1258: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1260: One line control clauses should not use braces. [whitespace/braces] [4] Source/WTF/wtf/FastMalloc.cpp:1260: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1265: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1270: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1276: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1281: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1286: The parameter name "object" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WTF/wtf/FastMalloc.cpp:1286: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1337: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1337: entropy_ is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WTF/wtf/FastMalloc.cpp:1656: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1657: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1657: entropy_ is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WTF/wtf/FastMalloc.cpp:1751: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1762: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1763: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:2000: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:2002: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:2014: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:2016: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:2063: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:2167: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:2169: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:2172: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:2174: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:2263: r_length is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WTF/wtf/FastMalloc.cpp:2395: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:2396: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:2424: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:2444: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:2478: One space before end of line comments [whitespace/comments] [5] Source/WTF/wtf/FastMalloc.cpp:2478: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:2478: list_ is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WTF/wtf/FastMalloc.cpp:2481: One space before end of line comments [whitespace/comments] [5] Source/WTF/wtf/FastMalloc.cpp:2481: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:2481: entropy_ is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WTF/wtf/FastMalloc.cpp:2484: Place brace on its own line for function definitions. [whitespace/braces] [4] Source/WTF/wtf/FastMalloc.cpp:2484: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:2485: Use 0 instead of NULL. [readability/null] [5] Source/WTF/wtf/FastMalloc.cpp:2508: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:2513: Place brace on its own line for function definitions. [whitespace/braces] [4] Source/WTF/wtf/FastMalloc.cpp:2513: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:2518: Place brace on its own line for function definitions. [whitespace/braces] [4] Source/WTF/wtf/FastMalloc.cpp:2518: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:2536: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:2537: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:2564: One space before end of line comments [whitespace/comments] [5] Source/WTF/wtf/FastMalloc.cpp:2564: Extra space between uintptr_t and entropy_ [whitespace/declaration] [3] Source/WTF/wtf/FastMalloc.cpp:2564: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:2564: entropy_ is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WTF/wtf/FastMalloc.cpp:2567: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:2576: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:2586: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:2586: size_class is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WTF/wtf/FastMalloc.cpp:2784: Place brace on its own line for function definitions. [whitespace/braces] [4] Source/WTF/wtf/FastMalloc.cpp:2784: TCMalloc_Central_FreeList::Init is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WTF/wtf/FastMalloc.cpp:2787: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:2789: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:2791: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:2792: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:2800: Place brace on its own line for function definitions. [whitespace/braces] [4] Source/WTF/wtf/FastMalloc.cpp:2800: TCMalloc_Central_FreeList::ReleaseListToSpans is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WTF/wtf/FastMalloc.cpp:2808: Place brace on its own line for function definitions. [whitespace/braces] [4] Source/WTF/wtf/FastMalloc.cpp:2809: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:2815: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:2826: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:2923: Place brace on its own line for function definitions. [whitespace/braces] [4] Source/WTF/wtf/FastMalloc.cpp:2923: TCMalloc_Central_FreeList::InsertRange is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WTF/wtf/FastMalloc.cpp:2938: Place brace on its own line for function definitions. [whitespace/braces] [4] Source/WTF/wtf/FastMalloc.cpp:2938: TCMalloc_Central_FreeList::RemoveRange is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WTF/wtf/FastMalloc.cpp:2953: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:2961: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:2962: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:2976: Place brace on its own line for function definitions. [whitespace/braces] [4] Source/WTF/wtf/FastMalloc.cpp:2976: TCMalloc_Central_FreeList::FetchFromSpansSafe is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WTF/wtf/FastMalloc.cpp:2977: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:2985: Place brace on its own line for function definitions. [whitespace/braces] [4] Source/WTF/wtf/FastMalloc.cpp:2985: TCMalloc_Central_FreeList::FetchFromSpans is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WTF/wtf/FastMalloc.cpp:2986: More than one command on the same line in if [whitespace/parens] [4] Source/WTF/wtf/FastMalloc.cpp:2986: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:2987: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:2989: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:2992: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:2993: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:2994: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:3038: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:3039: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:3041: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:3043: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:3050: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:3051: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:3052: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:3053: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:3058: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:3076: Place brace on its own line for function definitions. [whitespace/braces] [4] Source/WTF/wtf/FastMalloc.cpp:3076: TCMalloc_ThreadCache::Init is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WTF/wtf/FastMalloc.cpp:3082: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:3084: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:3120: Place brace on its own line for function definitions. [whitespace/braces] [4] Source/WTF/wtf/FastMalloc.cpp:3120: TCMalloc_ThreadCache::Deallocate is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WTF/wtf/FastMalloc.cpp:3134: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:3156: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespaceFailed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/FastMalloc.cpp', u'Source/WTF/wtf/MallocZoneSupport.h']" exit_code: 1 /indent] [3] Source/WTF/wtf/FastMalloc.cpp:3253: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:3263: Place brace on its own line for function definitions. [whitespace/braces] [4] Source/WTF/wtf/FastMalloc.cpp:3263: TCMalloc_ThreadCache::NewHeap is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WTF/wtf/FastMalloc.cpp:3266: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:3380: More than one command on the same line in if [whitespace/parens] [4] Source/WTF/wtf/FastMalloc.cpp:3380: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Source/WTF/wtf/FastMalloc.cpp:3380: Use 0 instead of NULL. [readability/null] [5] Source/WTF/wtf/FastMalloc.cpp:3882: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:3885: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:3886: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 195 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.

Oliver Hunt

Comment 3 2013-02-08 17:33:37 PST

Comment on attachment 187388 [details] Patch I have apparently managed to clobber performance now. sigh.

Oliver Hunt

Comment 4 2013-02-11 15:16:33 PST

Created attachment 187692 [details] Patch

WebKit Review Bot

Comment 5 2013-02-11 15:18:11 PST

Attachment 187692 [details] did not pass style-queue: Source/WTF/wtf/FastMalloc.cpp:547: Place brace on its own line for function definitions. [whitespace/braces] [4] Source/WTF/wtf/FastMalloc.cpp:695: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] Source/WTF/wtf/FastMalloc.cpp:727: One space before end of line comments [whitespace/comments] [5] Source/WTF/wtf/FastMalloc.cpp:727: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:728: One space before end of line comments [whitespace/comments] [5] Source/WTF/wtf/FastMalloc.cpp:728: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:754: Place brace on its own line for function definitions. [whitespace/braces] [4] Source/WTF/wtf/FastMalloc.cpp:758: Place brace on its own line for function definitions. [whitespace/braces] [4] Source/WTF/wtf/FastMalloc.cpp:762: Place brace on its own line for function definitions. [whitespace/braces] [4] Source/WTF/wtf/FastMalloc.cpp:763: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:767: Place brace on its own line for function definitions. [whitespace/braces] [4] Source/WTF/wtf/FastMalloc.cpp:768: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:769: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:778: Place brace on its own line for function definitions. [whitespace/braces] [4] Source/WTF/wtf/FastMalloc.cpp:785: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:792: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:794: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:797: Place brace on its own line for function definitions. [whitespace/braces] [4] Source/WTF/wtf/FastMalloc.cpp:799: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:803: Place brace on its own line for function definitions. [whitespace/braces] [4] Source/WTF/wtf/FastMalloc.cpp:1001: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1001: allocated_regions_ is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WTF/wtf/FastMalloc.cpp:1004: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1004: free_list_ is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WTF/wtf/FastMalloc.cpp:1008: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1008: entropy_ is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WTF/wtf/FastMalloc.cpp:1011: Place brace on its own line for function definitions. [whitespace/braces] [4] Source/WTF/wtf/FastMalloc.cpp:1011: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1017: Use 0 instead of NULL. [readability/null] [5] Source/WTF/wtf/FastMalloc.cpp:1025: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1026: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1034: _head is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WTF/wtf/FastMalloc.cpp:1049: _head is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WTF/wtf/FastMalloc.cpp:1061: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1062: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1103: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1104: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1105: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1106: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1107: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1113: One space before end of line comments [whitespace/comments] [5] Source/WTF/wtf/FastMalloc.cpp:1113: Extra space between HardenedSLL and objects [whitespace/declaration] [3] Source/WTF/wtf/FastMalloc.cpp:1113: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1169: Place brace on its own line for function definitions. [whitespace/braces] [4] Source/WTF/wtf/FastMalloc.cpp:1169: DLL_Init is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WTF/wtf/FastMalloc.cpp:1170: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1171: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1174: Place brace on its own line for function definitions. [whitespace/braces] [4] Source/WTF/wtf/FastMalloc.cpp:1174: DLL_Remove is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WTF/wtf/FastMalloc.cpp:1175: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1176: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1177: Use 0 instead of NULL. [readability/null] [5] Source/WTF/wtf/FastMalloc.cpp:1177: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1178: Use 0 instead of NULL. [readability/null] [5] Source/WTF/wtf/FastMalloc.cpp:1178: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1181: Place brace on its own line for function definitions. [whitespace/braces] [4] Source/WTF/wtf/FastMalloc.cpp:1182: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1185: Place brace on its own line for function definitions. [whitespace/braces] [4] Source/WTF/wtf/FastMalloc.cpp:1185: DLL_Length is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WTF/wtf/FastMalloc.cpp:1187: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1203: Place brace on its own line for function definitions. [whitespace/braces] [4] Source/WTF/wtf/FastMalloc.cpp:1203: DLL_Prepend is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WTF/wtf/FastMalloc.cpp:1204: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1205: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1206: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1207: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1216: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1222: The parameter name "N" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WTF/wtf/FastMalloc.cpp:1222: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1225: The parameter name "N" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WTF/wtf/FastMalloc.cpp:1225: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1244: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1245: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1246: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1247: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1258: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1260: One line control clauses should not use braces. [whitespace/braces] [4] Source/WTF/wtf/FastMalloc.cpp:1260: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1265: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1270: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1276: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1281: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1286: The parameter name "object" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WTF/wtf/FastMalloc.cpp:1286: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1337: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1337: entropy_ is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WTF/wtf/FastMalloc.cpp:1656: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1657: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1657: entropy_ is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WTF/wtf/FastMalloc.cpp:1751: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1762: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:1763: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:2000: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:2002: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:2014: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:2016: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:2063: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:2167: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:2169: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:2172: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:2174: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:2263: r_length is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WTF/wtf/FastMalloc.cpp:2395: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:2396: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:2424: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:2444: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:2478: One space before end of line comments [whitespace/comments] [5] Source/WTF/wtf/FastMalloc.cpp:2478: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:2478: list_ is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WTF/wtf/FastMalloc.cpp:2481: One space before end of line comments [whitespace/comments] [5] Source/WTF/wtf/FastMalloc.cpp:2481: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:2481: entropy_ is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WTF/wtf/FastMalloc.cpp:2484: Place brace on its own line for function definitions. [whitespace/braces] [4] Source/WTF/wtf/FastMalloc.cpp:2484: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:2485: Use 0 instead of NULL. [readability/null] [5] Source/WTF/wtf/FastMalloc.cpp:2508: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:2513: Place brace on its own line for function definitions. [whitespace/braces] [4] Source/WTF/wtf/FastMalloc.cpp:2513: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:2518: Place brace on its own line for function definitions. [whitespace/braces] [4] Source/WTF/wtf/FastMalloc.cpp:2518: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:2536: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:2537: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:2564: One space before end of line comments [whitespace/comments] [5] Source/WTF/wtf/FastMalloc.cpp:2564: Extra space between uintptr_t and entropy_ [whitespace/declaration] [3] Source/WTF/wtf/FastMalloc.cpp:2564: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:2564: entropy_ is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WTF/wtf/FastMalloc.cpp:2567: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:2576: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:2586: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:2586: size_class is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WTF/wtf/FastMalloc.cpp:2784: Place brace on its own line for function definitions. [whitespace/braces] [4] Source/WTF/wtf/FastMalloc.cpp:2784: TCMalloc_Central_FreeList::Init is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WTF/wtf/FastMalloc.cpp:2787: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:2789: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:2791: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:2792: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:2800: Place brace on its own line for function definitions. [whitespace/braces] [4] Source/WTF/wtf/FastMalloc.cpp:2800: TCMalloc_Central_FreeList::ReleaseListToSpans is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WTF/wtf/FastMalloc.cpp:2808: Place brace on its own line for function definitions. [whitespace/braces] [4] Source/WTF/wtf/FastMalloc.cpp:2809: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:2815: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:2826: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:2923: Place brace on its own line for function definitions. [whitespace/braces] [4] Source/WTF/wtf/FastMalloc.cpp:2923: TCMalloc_Central_FreeList::InsertRange is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WTF/wtf/FastMalloc.cpp:2938: Place brace on its own line for function definitions. [whitespace/braces] [4] Source/WTF/wtf/FastMalloc.cpp:2938: TCMalloc_Central_FreeList::RemoveRange is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WTF/wtf/FastMalloc.cpp:2953: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:2961: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:2962: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:2976: Place brace on its own line for function definitions. [whitespace/braces] [4] Source/WTF/wtf/FastMalloc.cpp:2976: TCMalloc_Central_FreeList::FetchFromSpansSafe is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WTF/wtf/FastMalloc.cpp:2977: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:2985: Place brace on its own line for function definitions. [whitespace/braces] [4] Source/WTF/wtf/FastMalloc.cpp:2985: TCMalloc_Central_FreeList::FetchFromSpans is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WTF/wtf/FastMalloc.cpp:2986: More than one command on the same line in if [whitespace/parens] [4] Source/WTF/wtf/FastMalloc.cpp:2986: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:2987: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:2989: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:2992: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:2993: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:2994: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:3038: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:3039: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:3041: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:3043: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:3050: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:3051: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:3052: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:3053: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:3058: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:3076: Place brace on its own line for function definitions. [whitespace/braces] [4] Source/WTF/wtf/FastMalloc.cpp:3076: TCMalloc_ThreadCache::Init is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WTF/wtf/FastMalloc.cpp:3082: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:3084: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:3120: Place brace on its own line for function definitions. [whitespace/braces] [4] Source/WTF/wtf/FastMalloc.cpp:3120: TCMalloc_ThreadCache::Deallocate is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WTF/wtf/FastMalloc.cpp:3134: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:3156: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:3253: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:3263: Place brace on its own line for function definitions. [whitespace/braces] [4] Source/WTF/wtf/FastMalloc.cpp:3263: TCMalloc_ThreadCache::NewHeap is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WTF/wtf/FastMalloc.cpp:3266: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:3380: More than one command on the same line in if [whitespace/parens] [4] Source/WTF/wtf/FastMalloc.cpp:3380: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Source/WTF/wtf/FastMalloc.cpp:3380: Use 0 instead of NULL. [readability/null] [5] Source/WTF/wtf/FastMalloc.cpp:3882: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTFailed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/FastMalloc.cpp', u'Source/WTF/wtf/MallocZoneSupport.h']" exit_code: 1 F/wtf/FastMalloc.cpp:3885: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:3886: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 188 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.

Mark Hahnenberg

Comment 6 2013-02-11 15:51:29 PST

Comment on attachment 187692 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=187692&action=review r=me with comments. > Source/WTF/ChangeLog:17 > + I've also made an explicit struct type forthe FastMalloc singly linked for the > Source/WTF/wtf/FastMalloc.cpp:695 > +// Hardened singly linked list. We make this a struct to allow compiler to s/struct/class > Source/WTF/wtf/FastMalloc.cpp:4549 > + ASSERT(localAddress); > + if (!localAddress) > + return 0; We didn't ASSERT in the old code. Are you sure this is okay?

Oliver Hunt

Comment 7 2013-02-11 15:54:53 PST

Committed r142536: <http://trac.webkit.org/changeset/142536>

Note You need to log in before you can comment on or make changes to this bug.