Bug 109322

Summary: AX: move isIgnored caching to AXObject
Product: WebKit Reporter: Dominic Mazzoni <dmazzoni>
Component: AccessibilityAssignee: Dominic Mazzoni <dmazzoni>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, apinheiro, cfleizach, dglazkov, eric.carlson, feature-media-reviews, jdiggs, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing none

Dominic Mazzoni
Reported 2013-02-08 13:29:44 PST
There's some benefit to caching accessibilityIsIgnored (using AXComputedObjectAttributeCache) for more than just AXRenderObject, so rather than duplicating a bunch of code, that code should probably be in AXObject.
Attachments
Patch (38.77 KB, patch)
2013-02-08 13:39 PST, Dominic Mazzoni 		no flags
DetailsFormatted DiffDiff
Patch (39.00 KB, patch)
2013-02-08 13:59 PST, Dominic Mazzoni 		no flags
DetailsFormatted DiffDiff
Patch for landing (39.28 KB, patch)
2013-02-09 13:54 PST, Dominic Mazzoni 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Dominic Mazzoni
Comment 1 2013-02-08 13:39:17 PST
Created attachment 187359 [details] Patch
WebKit Review Bot
Comment 2 2013-02-08 13:47:27 PST
Comment on attachment 187359 [details] Patch Attachment 187359 [details] did not pass cr-linux-debug-ews (chromium-xvfb): Output: http://queues.webkit.org/results/16435808
Dominic Mazzoni
Comment 3 2013-02-08 13:59:00 PST
Created attachment 187361 [details] Patch
chris fleizach
Comment 4 2013-02-08 17:49:31 PST
Comment on attachment 187361 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=187361&action=review > Source/WebCore/accessibility/AccessibilityRenderObject.h:97 > + virtual bool computeAccessibilityIsIgnored() const; looks like this should be private too
Dominic Mazzoni
Comment 5 2013-02-09 13:54:12 PST
Created attachment 187445 [details] Patch for landing
WebKit Review Bot
Comment 6 2013-02-09 15:07:39 PST
Comment on attachment 187445 [details] Patch for landing Clearing flags on attachment: 187445 Committed r142382: <http://trac.webkit.org/changeset/142382>
WebKit Review Bot
Comment 7 2013-02-09 15:07:45 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.