Bug 109300

Summary: [BlackBerry] Add form navigation control state tracking.
Product: WebKit Reporter: Mike Fenton <mifenton>
Component: WebKit BlackBerryAssignee: Mike Fenton <mifenton>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, rniwa, rwlbuis, tonikitoo, webkit.review.bot, yong.li.webkit
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
buildbot: commit-queue-
Updated Patch
none
Updated patch with better variable naming. none

Description Mike Fenton 2013-02-08 07:13:01 PST
SSIA.
Comment 1 Mike Fenton 2013-02-08 07:14:03 PST
Created attachment 187315 [details]
Patch
Comment 2 WebKit Review Bot 2013-02-08 07:31:35 PST
Attachment 187315 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/blackberry/Api/WebPage.cpp', u'Source/WebKit/blackberry/Api/WebPage.h', u'Source/WebKit/blackberry/Api/WebPageClient.h', u'Source/WebKit/blackberry/ChangeLog', u'Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp', u'Source/WebKit/blackberry/WebKitSupport/InputHandler.h']" exit_code: 1
Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp:934:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp:936:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp:938:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp:939:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp:940:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp:941:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp:942:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp:943:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp:944:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp:945:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp:946:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp:947:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp:948:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp:949:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp:950:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp:951:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp:952:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp:953:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp:954:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp:955:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 20 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Build Bot 2013-02-08 09:32:34 PST
Comment on attachment 187315 [details]
Patch

Attachment 187315 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://queues.webkit.org/results/16443652

New failing tests:
http/tests/cache/cached-main-resource.html
Comment 4 Mike Fenton 2013-02-08 11:35:27 PST
Created attachment 187341 [details]
Updated Patch
Comment 5 Rob Buis 2013-02-11 08:45:45 PST
Comment on attachment 187341 [details]
Updated Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=187341&action=review

> Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp:948
> +        for (int j = i + 1; j < formElementCount; j++) {

I think using j twice is confusing. Most compilers can probably deal with it but better not risk anything, and maybe choose more descriptive variable names.
Comment 6 Mike Fenton 2013-02-11 08:52:01 PST
Created attachment 187587 [details]
Updated patch with better variable naming.
Comment 7 Rob Buis 2013-02-11 08:54:39 PST
Comment on attachment 187587 [details]
Updated patch with better variable naming.

LGTM.
Comment 8 WebKit Review Bot 2013-02-11 09:19:24 PST
Comment on attachment 187587 [details]
Updated patch with better variable naming.

Clearing flags on attachment: 187587

Committed r142482: <http://trac.webkit.org/changeset/142482>
Comment 9 WebKit Review Bot 2013-02-11 09:19:28 PST
All reviewed patches have been landed.  Closing bug.