Bug 109292 – RTCPeerConnection.getStats() fails when remote stats are instantiated.

• Component: WebCore Misc.
• Status: RESOLVED FIXED

[Harald Alvestrand]

Assert failure observed. Stack trace:

webkit!WebCore::RTCStatsReport::addElement+0xe4
webkit!WebCore::RTCStatsResponse::addElement+0x6b
webkit!WebKit::WebRTCStatsResponse::addElement+0x44
content!content::LocalRTCStatsResponse::addElement+0x2f
content!content::StatsResponse::AddElement+0x72
content!content::StatsResponse::OnComplete+0x149
content!webrtc::PeerConnection::OnMessage+0x21c
content!jingle_glue::JingleThreadWrapper::RunTask+0x283

Code:

void RTCStatsReport::addElement(bool isLocal, double timestamp)
{
    if (isLocal) {
        ASSERT(!m_local);
        m_local = RTCStatsElement::create(timestamp);
    }
    ASSERT(!m_remote);  <<============================================
    m_remote = RTCStatsElement::create(timestamp);
}

Missing RETURN inside if block.

[Harald Alvestrand]

Created attachment 187308 [details]
Patch

[WebKit Review Bot]

Comment on attachment 187308 [details]
Patch

Clearing flags on attachment: 187308

Committed r142289: <http://trac.webkit.org/changeset/142289>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.