| Summary: | [Curl] setCookiesFromDOM function does not save cookies to disk. | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | peavo | ||||||
| Component: | WebCore Misc. | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | bfulgham, webkit.review.bot | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | All | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
peavo
2013-02-08 04:23:08 PST
Created attachment 187292 [details]
Patch
Comment on attachment 187292 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=187292&action=review Very nice update. Please switch to an "early return" style for that one method, since no other actions are taken in the case where the CURL handle is null. > Source/WebCore/platform/network/curl/CookieJarCurl.cpp:37 > + if (curl) { Please make this an early return, since we do nothing if the curl interface is not present. Created attachment 187545 [details]
Patch
Updated patch according to the review comments, and set Curl option to share the Curl cookie database, when adding the cookie. Comment on attachment 187545 [details]
Patch
Looks great! Thanks for getting this working.
Comment on attachment 187545 [details] Patch Clearing flags on attachment: 187545 Committed r142574: <http://trac.webkit.org/changeset/142574> All reviewed patches have been landed. Closing bug. (In reply to comment #5) > (From update of attachment 187545 [details]) > Looks great! Thanks for getting this working. Thanks alot for the review ;) |