Bug 109269

Summary: [chromium] copy normalizeLayoutTestURL code to TestRunner library
Product: WebKit Reporter: jochen
Component: New BugsAssignee: jochen
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dglazkov, fishd, jamesr, tkent+wkapi, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description jochen 2013-02-08 00:34:55 PST
[chromium] copy normalizeLayoutTestURL code to TestRunner library
Comment 1 jochen 2013-02-08 00:36:41 PST
Created attachment 187257 [details]
Patch
Comment 2 WebKit Review Bot 2013-02-08 00:39:35 PST
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 3 Kent Tamura 2013-02-08 00:42:01 PST
Comment on attachment 187257 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=187257&action=review

> Tools/DumpRenderTree/chromium/TestShell.cpp:-831
> -    return normalizeLayoutTestURLInternal(url);

Don't you remove normalizeLayoutTestURLInternal?
Comment 4 jochen 2013-02-08 01:01:22 PST
Comment on attachment 187257 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=187257&action=review

>> Tools/DumpRenderTree/chromium/TestShell.cpp:-831
>> -    return normalizeLayoutTestURLInternal(url);
> 
> Don't you remove normalizeLayoutTestURLInternal?

it's still used in TestShell itself.
Comment 5 jochen 2013-02-08 03:06:06 PST
Created attachment 187274 [details]
Patch
Comment 6 WebKit Review Bot 2013-02-08 03:53:08 PST
Comment on attachment 187274 [details]
Patch

Clearing flags on attachment: 187274

Committed r142253: <http://trac.webkit.org/changeset/142253>
Comment 7 WebKit Review Bot 2013-02-08 03:53:11 PST
All reviewed patches have been landed.  Closing bug.