Summary: | [chromium] copy normalizeLayoutTestURL code to TestRunner library | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | jochen | ||||||
Component: | New Bugs | Assignee: | jochen | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | abarth, dglazkov, fishd, jamesr, tkent+wkapi, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
jochen
2013-02-08 00:34:55 PST
Created attachment 187257 [details]
Patch
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI. Comment on attachment 187257 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=187257&action=review > Tools/DumpRenderTree/chromium/TestShell.cpp:-831 > - return normalizeLayoutTestURLInternal(url); Don't you remove normalizeLayoutTestURLInternal? Comment on attachment 187257 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=187257&action=review >> Tools/DumpRenderTree/chromium/TestShell.cpp:-831 >> - return normalizeLayoutTestURLInternal(url); > > Don't you remove normalizeLayoutTestURLInternal? it's still used in TestShell itself. Created attachment 187274 [details]
Patch
Comment on attachment 187274 [details] Patch Clearing flags on attachment: 187274 Committed r142253: <http://trac.webkit.org/changeset/142253> All reviewed patches have been landed. Closing bug. |