RESOLVED FIXED 109269
[chromium] copy normalizeLayoutTestURL code to TestRunner library 
https://bugs.webkit.org/show_bug.cgi?id=109269
Summary [chromium] copy normalizeLayoutTestURL code to TestRunner library
jochen
Reported 2013-02-08 00:34:55 PST
[chromium] copy normalizeLayoutTestURL code to TestRunner library
Attachments
Patch (7.92 KB, patch)
2013-02-08 00:36 PST, jochen 		no flags
DetailsFormatted DiffDiff
Patch (8.03 KB, patch)
2013-02-08 03:06 PST, jochen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
jochen
Comment 1 2013-02-08 00:36:41 PST
Created attachment 187257 [details] Patch
WebKit Review Bot
Comment 2 2013-02-08 00:39:35 PST
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Kent Tamura
Comment 3 2013-02-08 00:42:01 PST
Comment on attachment 187257 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=187257&action=review > Tools/DumpRenderTree/chromium/TestShell.cpp:-831 > - return normalizeLayoutTestURLInternal(url); Don't you remove normalizeLayoutTestURLInternal?
jochen
Comment 4 2013-02-08 01:01:22 PST
Comment on attachment 187257 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=187257&action=review >> Tools/DumpRenderTree/chromium/TestShell.cpp:-831 >> - return normalizeLayoutTestURLInternal(url); > > Don't you remove normalizeLayoutTestURLInternal? it's still used in TestShell itself.
jochen
Comment 5 2013-02-08 03:06:06 PST
Created attachment 187274 [details] Patch
WebKit Review Bot
Comment 6 2013-02-08 03:53:08 PST
Comment on attachment 187274 [details] Patch Clearing flags on attachment: 187274 Committed r142253: <http://trac.webkit.org/changeset/142253>
WebKit Review Bot
Comment 7 2013-02-08 03:53:11 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.