| Summary: | {FocusIn,FocusOut,Focus,Blur}EventDispatchMediator should be in FocusEvent.cpp | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Kentaro Hara <haraken> | ||||||
| Component: | DOM | Assignee: | Kentaro Hara <haraken> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | abarth, eric.carlson, feature-media-reviews, hayato, ojan.autocc, ojan, webkit.review.bot | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
Created attachment 187253 [details]
Patch
Attachment 187253 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/dom/EventDispatchMediator.cpp', u'Source/WebCore/dom/EventDispatchMediator.h', u'Source/WebCore/dom/FocusEvent.cpp', u'Source/WebCore/dom/FocusEvent.h', u'Source/WebCore/dom/UIEvent.cpp', u'Source/WebCore/dom/UIEvent.h']" exit_code: 1
Source/WebCore/dom/FocusEvent.cpp:31: Alphabetical sorting problem. [build/include_order] [4]
Total errors found: 1 in 3 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 187255 [details]
Patch
Comment on attachment 187255 [details] Patch Clearing flags on attachment: 187255 Committed r142329: <http://trac.webkit.org/changeset/142329> All reviewed patches have been landed. Closing bug. |
Conventionally we put XXXEventDispatchMediator to XXXEvent.cpp. We should move {FocusIn,FocusOut,Focus,Blur}EventDispatchMediator to FocusEvent.cpp.