Bug 109265

Summary: {FocusIn,FocusOut,Focus,Blur}EventDispatchMediator should be in FocusEvent.cpp
Product: WebKit Reporter: Kentaro Hara <haraken>
Component: DOMAssignee: Kentaro Hara <haraken>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric.carlson, feature-media-reviews, hayato, ojan.autocc, ojan, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Kentaro Hara
Reported 2013-02-08 00:14:06 PST
Conventionally we put XXXEventDispatchMediator to XXXEvent.cpp. We should move {FocusIn,FocusOut,Focus,Blur}EventDispatchMediator to FocusEvent.cpp.
Attachments
Patch (12.73 KB, patch)
2013-02-08 00:18 PST, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
Patch (12.76 KB, patch)
2013-02-08 00:23 PST, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Kentaro Hara
Comment 1 2013-02-08 00:18:10 PST
Created attachment 187253 [details] Patch
WebKit Review Bot
Comment 2 2013-02-08 00:22:30 PST
Attachment 187253 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/dom/EventDispatchMediator.cpp', u'Source/WebCore/dom/EventDispatchMediator.h', u'Source/WebCore/dom/FocusEvent.cpp', u'Source/WebCore/dom/FocusEvent.h', u'Source/WebCore/dom/UIEvent.cpp', u'Source/WebCore/dom/UIEvent.h']" exit_code: 1 Source/WebCore/dom/FocusEvent.cpp:31: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Kentaro Hara
Comment 3 2013-02-08 00:23:35 PST
Created attachment 187255 [details] Patch
WebKit Review Bot
Comment 4 2013-02-08 16:21:54 PST
Comment on attachment 187255 [details] Patch Clearing flags on attachment: 187255 Committed r142329: <http://trac.webkit.org/changeset/142329>
WebKit Review Bot
Comment 5 2013-02-08 16:21:58 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.