Bug 109265 - {FocusIn,FocusOut,Focus,Blur}EventDispatchMediator should be in FocusEvent.cpp
Summary: {FocusIn,FocusOut,Focus,Blur}EventDispatchMediator should be in FocusEvent.cpp
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kentaro Hara
Depends on:
Reported: 2013-02-08 00:14 PST by Kentaro Hara
Modified: 2013-02-08 16:21 PST (History)
7 users (show)

See Also:

Patch (12.73 KB, patch)
2013-02-08 00:18 PST, Kentaro Hara
no flags Details | Formatted Diff | Diff
Patch (12.76 KB, patch)
2013-02-08 00:23 PST, Kentaro Hara
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kentaro Hara 2013-02-08 00:14:06 PST
Conventionally we put XXXEventDispatchMediator to XXXEvent.cpp. We should move {FocusIn,FocusOut,Focus,Blur}EventDispatchMediator to FocusEvent.cpp.
Comment 1 Kentaro Hara 2013-02-08 00:18:10 PST
Created attachment 187253 [details]
Comment 2 WebKit Review Bot 2013-02-08 00:22:30 PST
Attachment 187253 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/dom/EventDispatchMediator.cpp', u'Source/WebCore/dom/EventDispatchMediator.h', u'Source/WebCore/dom/FocusEvent.cpp', u'Source/WebCore/dom/FocusEvent.h', u'Source/WebCore/dom/UIEvent.cpp', u'Source/WebCore/dom/UIEvent.h']" exit_code: 1
Source/WebCore/dom/FocusEvent.cpp:31:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 3 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Kentaro Hara 2013-02-08 00:23:35 PST
Created attachment 187255 [details]
Comment 4 WebKit Review Bot 2013-02-08 16:21:54 PST
Comment on attachment 187255 [details]

Clearing flags on attachment: 187255

Committed r142329: <http://trac.webkit.org/changeset/142329>
Comment 5 WebKit Review Bot 2013-02-08 16:21:58 PST
All reviewed patches have been landed.  Closing bug.