Bug 10924
| Summary: | Layout test failures, extra WebViewDidChangeSelectionNotification sent | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Timothy Hatcher <timothy> |
| Component: | HTML Editing | Assignee: | Alice Liu <alice.barraclough> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | aroben, justin.garcia, timothy |
| Priority: | P2 | Keywords: | LayoutTestFailure |
| Version: | 420+ | ||
| Hardware: | Mac | ||
| OS: | OS X 10.4 | ||
Timothy Hatcher
These tests sent an extra WebViewDidChangeSelectionNotification notification when the selection changes:
css2.1/t0801-c412-hz-box-00-b-a.html
editing/pasteboard/copy-paste-bidi.html
fast/dynamic/move-node-with-selection.html
fast/events/dblclick-addEventListener.html
fast/events/updateLayoutForHitTest.html
EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
+EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Adam Roben (:aroben)
css2.1/t0801-c412-hz-box-00-b-a.html suffers from a separate problem (catalogued in bug 11000). Adittionally, fast/forms/display-none-in-onchange-keyboard.html seems to now be missing a call to this delegate notification.
Alice Liu
These three tests have new results checked in:
fast/dynamic/move-node-with-selection.html
fast/events/dblclick-addEventListener.html
fast/events/updateLayoutForHitTest.html
these 2 are broken for different reasons, and separate bugs should be filed about them.
css2.1/t0801-c412-hz-box-00-b-a.html
editing/pasteboard/copy-paste-bidi.html
resolving this bug since this bug has to do with the problem of extra calls to WebViewDidChangeSelectionNotification
Alice Liu
r17084
Adam Roben (:aroben)
The explanation, cribbed from Alice's ChangeLog:
When nodes are removed, selections are cleared, and when http://bugs.webkit.org/show_bug.cgi?id=6498 was fixed, we started sending didChangeSelection notifications.