WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
6498
SelectionController's setters should notify delegates of selection changes
https://bugs.webkit.org/show_bug.cgi?id=6498
Summary
SelectionController's setters should notify delegates of selection changes
Justin Garcia
Reported
2006-01-11 19:55:26 PST
To get selection notifications sent to delegates, you have to call m_frame->setSelection(). This idiosyncrasy caused a layout test failure after maciej removed clearSelection() { m_frame->setSelection (SelectionController()) } and replaced calls to it with selection().clear(). Since it's non-obvious, and since I want to make the JS Selection Object a wrapper around a SelectionController and not an m_frame, I want to fix this.
Attachments
patch w/o layout test changes
(99.37 KB, patch)
2006-08-31 17:48 PDT
,
Justin Garcia
no flags
Details
Formatted Diff
Diff
patch w/o layout test changes
(99.85 KB, patch)
2006-08-31 17:58 PDT
,
Justin Garcia
no flags
Details
Formatted Diff
Diff
patch w/o layout test changes
(99.55 KB, patch)
2006-08-31 20:46 PDT
,
Justin Garcia
justin.garcia
: review+
Details
Formatted Diff
Diff
Show Obsolete
(2)
View All
Add attachment
proposed patch, testcase, etc.
Justin Garcia
Comment 1
2006-08-31 17:48:59 PDT
Created
attachment 10340
[details]
patch w/o layout test changes Not included in the patch is a layout test and changes to layout test results (nearly all editing layout tests have extra didChangeSelection calls from Selection changes that weren't reported before).
Justin Garcia
Comment 2
2006-08-31 17:58:03 PDT
Created
attachment 10341
[details]
patch w/o layout test changes
Justin Garcia
Comment 3
2006-08-31 20:46:42 PDT
Created
attachment 10344
[details]
patch w/o layout test changes
Justin Garcia
Comment 4
2006-09-01 17:38:20 PDT
Comment on
attachment 10344
[details]
patch w/o layout test changes tim reviewed this
Justin Garcia
Comment 5
2006-09-05 15:29:09 PDT
r16237
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug