Bug 109239

Summary:

Move workerThreadCount from TestRunner to WebCore Internals

Product:

WebKit

Reporter:

Benjamin Poulain <benjamin>

Component:

New Bugs

Assignee:

Benjamin Poulain <benjamin>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, dglazkov, gtk-ews, gyuyoung.kim, jochen, mifenton, peter+ews, philn, rakuco, rego+ews, rniwa, rwlbuis, tonikitoo, webkit-ews, webkit.review.bot, xan.lopez, yong.li.webkit

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	webkit-ews: commit-queue-
Patch	none

Benjamin Poulain

Reported 2013-02-07 16:17:20 PST

Move workerThreadCount from TestRunner to WebCore Internals

Attachments
Patch (45.82 KB, patch) 2013-02-07 16:20 PST, Benjamin Poulain	no flags	Details Formatted Diff Diff
Patch (48.32 KB, patch) 2013-02-08 01:48 PST, Benjamin Poulain	webkit-ews: commit-queue-	Details Formatted Diff Diff
Patch (48.31 KB, patch) 2013-02-08 12:28 PST, Benjamin Poulain	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Benjamin Poulain

Comment 1 2013-02-07 16:20:17 PST

Created attachment 187193 [details] Patch

Benjamin Poulain

Comment 2 2013-02-07 17:37:22 PST

Damn, why does it always have to be GTK :( :( I'll add the symbol before landing.

kov's GTK+ EWS bot

Comment 3 2013-02-07 18:54:33 PST

Comment on attachment 187193 [details] Patch Attachment 187193 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/16427430

Darin Adler

Comment 4 2013-02-07 20:16:46 PST

Comment on attachment 187193 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=187193&action=review Please check into the GTK build failure before landing. > Source/WebCore/testing/Internals.h:209 > + unsigned long workerThreadCount() const; IDL unsigned long is equivalent to C++ unsigned, just as IDL long is equivalent to C++ int. It’s incorrect to use unsigned long here.

Build Bot

Comment 5 2013-02-08 01:01:42 PST

Comment on attachment 187193 [details] Patch Attachment 187193 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/16427530

Benjamin Poulain

Comment 6 2013-02-08 01:45:49 PST

> > Source/WebCore/testing/Internals.h:209 > > + unsigned long workerThreadCount() const; > > IDL unsigned long is equivalent to C++ unsigned, just as IDL long is equivalent to C++ int. It’s incorrect to use unsigned long here. Good catch! An unfortunate copy-paste.

Benjamin Poulain

Comment 7 2013-02-08 01:48:03 PST

Created attachment 187268 [details] Patch

Early Warning System Bot

Comment 8 2013-02-08 01:56:30 PST

Comment on attachment 187268 [details] Patch Attachment 187268 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/16445616

WebKit Review Bot

Comment 9 2013-02-08 01:56:54 PST

Comment on attachment 187268 [details] Patch Attachment 187268 [details] did not pass cr-linux-debug-ews (chromium-xvfb): Output: http://queues.webkit.org/results/16428580

WebKit Review Bot

Comment 10 2013-02-08 01:59:05 PST

Comment on attachment 187268 [details] Patch Attachment 187268 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/16453015