| Summary: | Move workerThreadCount from TestRunner to WebCore Internals | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Benjamin Poulain <benjamin> | ||||||||
| Component: | New Bugs | Assignee: | Benjamin Poulain <benjamin> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | buildbot, dglazkov, gtk-ews, gyuyoung.kim, jochen, mifenton, peter+ews, philn, rakuco, rego+ews, rniwa, rwlbuis, tonikitoo, webkit-ews, webkit.review.bot, xan.lopez, yong.li.webkit | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Benjamin Poulain
2013-02-07 16:17:20 PST
Created attachment 187193 [details]
Patch
Damn, why does it always have to be GTK :( :( I'll add the symbol before landing. Comment on attachment 187193 [details] Patch Attachment 187193 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/16427430 Comment on attachment 187193 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=187193&action=review Please check into the GTK build failure before landing. > Source/WebCore/testing/Internals.h:209 > + unsigned long workerThreadCount() const; IDL unsigned long is equivalent to C++ unsigned, just as IDL long is equivalent to C++ int. It’s incorrect to use unsigned long here. Comment on attachment 187193 [details] Patch Attachment 187193 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/16427530 > > Source/WebCore/testing/Internals.h:209
> > + unsigned long workerThreadCount() const;
>
> IDL unsigned long is equivalent to C++ unsigned, just as IDL long is equivalent to C++ int. It’s incorrect to use unsigned long here.
Good catch! An unfortunate copy-paste.
Created attachment 187268 [details]
Patch
Comment on attachment 187268 [details] Patch Attachment 187268 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/16445616 Comment on attachment 187268 [details] Patch Attachment 187268 [details] did not pass cr-linux-debug-ews (chromium-xvfb): Output: http://queues.webkit.org/results/16428580 Comment on attachment 187268 [details] Patch Attachment 187268 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/16453015 Comment on attachment 187268 [details] Patch Attachment 187268 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/16435551 Comment on attachment 187268 [details] Patch Attachment 187268 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/16408680 Comment on attachment 187268 [details] Patch Attachment 187268 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/16415673 Comment on attachment 187268 [details] Patch Attachment 187268 [details] did not pass cr-android-ews (chromium-android): Output: http://queues.webkit.org/results/16443527 Comment on attachment 187268 [details] Patch Attachment 187268 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://queues.webkit.org/results/16432580 Created attachment 187348 [details]
Patch
Comment on attachment 187348 [details] Patch Clearing flags on attachment: 187348 Committed r142348: <http://trac.webkit.org/changeset/142348> All reviewed patches have been landed. Closing bug. |