Summary: | [GTK] Cleanup command-line defines | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Martin Robinson <mrobinson> | ||||||||
Component: | WebKitGTK | Assignee: | Martin Robinson <mrobinson> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | webkit.review.bot, zan | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Martin Robinson
2013-02-07 11:11:11 PST
Created attachment 187139 [details]
Patch
Comment on attachment 187139 [details]
Patch
I assume there's really no reason to define some things to 1 and others to nothing (ie, just define th esymbol), so I'd rather make it consistent while we are at it. Other than that it makes sense to me.
Created attachment 187158 [details]
Patch
Comment on attachment 187158 [details] Patch Rejecting attachment 187158 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=gce-cq-02', 'validate-changelog', '--non-interactive', 187158, '--port=chromium-xvfb']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue /mnt/git/webkit-commit-queue/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/16426341 Created attachment 187161 [details]
Patch
Committed r142179: <http://trac.webkit.org/changeset/142179> |