Bug 109213

Summary: [GTK] Cleanup command-line defines
Product: WebKit Reporter: Martin Robinson <mrobinson>
Component: WebKitGTKAssignee: Martin Robinson <mrobinson>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot, zan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Martin Robinson
Reported 2013-02-07 11:11:11 PST
A lot of defines are set in the command-line via automake. This means that the command-line is very long and that other build systems using autoconf cannot share the defines.
Attachments
Patch (17.75 KB, patch)
2013-02-07 11:43 PST, Martin Robinson 		no flags
DetailsFormatted DiffDiff
Patch (17.98 KB, patch)
2013-02-07 13:07 PST, Martin Robinson 		no flags
DetailsFormatted DiffDiff
Patch (17.74 KB, patch)
2013-02-07 13:20 PST, Martin Robinson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Martin Robinson
Comment 1 2013-02-07 11:43:05 PST
Created attachment 187139 [details] Patch
Xan Lopez
Comment 2 2013-02-07 12:12:27 PST
Comment on attachment 187139 [details] Patch I assume there's really no reason to define some things to 1 and others to nothing (ie, just define th esymbol), so I'd rather make it consistent while we are at it. Other than that it makes sense to me.
Martin Robinson
Comment 3 2013-02-07 13:07:03 PST
Created attachment 187158 [details] Patch
WebKit Review Bot
Comment 4 2013-02-07 13:16:39 PST
Comment on attachment 187158 [details] Patch Rejecting attachment 187158 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=gce-cq-02', 'validate-changelog', '--non-interactive', 187158, '--port=chromium-xvfb']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue /mnt/git/webkit-commit-queue/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/16426341
Martin Robinson
Comment 5 2013-02-07 13:20:52 PST
Created attachment 187161 [details] Patch
Martin Robinson
Comment 6 2013-02-07 14:09:40 PST
Committed r142179: <http://trac.webkit.org/changeset/142179>
Note You need to log in before you can comment on or make changes to this bug.