Bug 109192

Summary: Web Inspector: expose did{Begin,Cancel}Frame() and {will,did}Composite() on WebDebToolsAgent
Product: WebKit Reporter: Andrey Kosyakov <caseq>
Component: Web Inspector (Deprecated)Assignee: Andrey Kosyakov <caseq>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, apavlov, buildbot, dglazkov, fishd, jamesr, keishi, loislo, mifenton, pfeldman, pmuellr, rego+ews, rniwa, rwlbuis, tkent+wkapi, tonikitoo, vsevik, web-inspector-bugs, webkit.review.bot, xan.lopez, yong.li.webkit, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
pfeldman: review+, buildbot: commit-queue-
Patch
buildbot: commit-queue-
Patch buildbot: commit-queue-

Description Andrey Kosyakov 2013-02-07 08:09:20 PST
This removes frame and compositing instrumentation methods from InspectorInstrumentation and exposes them via WebDevToolsAgent. The plan is to remove these methods from WebWidget interface and use methods on WebDevToolsAgent instead.
Comment 1 Andrey Kosyakov 2013-02-07 08:13:28 PST
Created attachment 187114 [details]
Patch
Comment 2 WebKit Review Bot 2013-02-07 08:14:46 PST
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 3 Build Bot 2013-02-07 10:01:22 PST
Comment on attachment 187114 [details]
Patch

Attachment 187114 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://queues.webkit.org/results/16418255
Comment 4 Build Bot 2013-02-07 10:30:57 PST
Comment on attachment 187114 [details]
Patch

Attachment 187114 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/16408384
Comment 5 Build Bot 2013-02-07 16:20:42 PST
Comment on attachment 187114 [details]
Patch

Attachment 187114 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/16418391
Comment 6 Pavel Feldman 2013-02-07 23:52:09 PST
Comment on attachment 187114 [details]
Patch

Watch out for the wk bot failures
Comment 7 Andrey Kosyakov 2013-02-08 02:28:07 PST
Created attachment 187272 [details]
Patch
Comment 8 Build Bot 2013-02-08 02:52:01 PST
Comment on attachment 187272 [details]
Patch

Attachment 187272 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/16434574
Comment 9 Build Bot 2013-02-08 02:54:03 PST
Comment on attachment 187272 [details]
Patch

Attachment 187272 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://queues.webkit.org/results/16428594
Comment 10 Andrey Kosyakov 2013-02-08 08:27:07 PST
Created attachment 187324 [details]
Patch
Comment 11 James Robinson 2013-02-08 19:36:44 PST
Great, this definitely works for me.  I'll rebase my patch on top of this after it lands.  Thanks!
Comment 12 Build Bot 2013-02-11 15:32:25 PST
Comment on attachment 187324 [details]
Patch

Attachment 187324 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/16501381
Comment 13 James Robinson 2013-02-12 13:52:59 PST
What's the status here?  Is there any way I can help?
Comment 14 Build Bot 2013-02-12 15:17:19 PST
Comment on attachment 187272 [details]
Patch

Attachment 187272 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/16513436
Comment 15 Andrey Kosyakov 2013-02-14 08:41:12 PST
Committed r142879: <http://trac.webkit.org/changeset/142879>