Bug 109188

Summary: [EFL] Add a WebKit2 Performance bot.
Product: WebKit Reporter: Raphael Kubo da Costa (:rakuco) <rakuco>
Component: Tools / TestsAssignee: Raphael Kubo da Costa (:rakuco) <rakuco>
Status: RESOLVED FIXED    
Severity: Normal CC: d-r, lforschler, ossy, rniwa, tmpsantos
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 109342    
Attachments:
Description Flags
Patch
none
Patch for landing none

Raphael Kubo da Costa (:rakuco)
Reported 2013-02-07 06:50:27 PST
[EFL] Add a WebKit2 Performance bot.
Attachments
Patch (3.03 KB, patch)
2013-02-07 06:51 PST, Raphael Kubo da Costa (:rakuco) 		no flags
DetailsFormatted DiffDiff
Patch for landing (3.04 KB, patch)
2013-02-07 07:34 PST, Raphael Kubo da Costa (:rakuco) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Raphael Kubo da Costa (:rakuco)
Comment 1 2013-02-07 06:51:42 PST
Created attachment 187095 [details] Patch
Raphael Kubo da Costa (:rakuco)
Comment 2 2013-02-07 06:53:04 PST
I've CC'ed Ossy in case he's willing to double-check the config.json changes. I guess the bot first needs to be active in build.webkit.org, so I'd need to set things up with Lucas before hooking the new machine into appspot.com with Ryosuke, right?
Lucas Forschler
Comment 3 2013-02-07 07:00:21 PST
I've added the bot password to the webkit build master and sent it to you via email. After this patch lands, you should be able to connect.
Csaba Osztrogonác
Comment 4 2013-02-07 07:23:50 PST
Comment on attachment 187095 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=187095&action=review LGTM with a typo fix. > Tools/BuildSlaveSupport/build.webkit.org-config/config.json:350 > + "name": "EFL Linux 64-bit Release WK2 (Perf)", "type": "BuildAndPerfTestWebKit2", "builddir": "efl-linux-64-release-wk2-perf", I assume you meant DownloadAndPerfTestWebKit2 instead of BuildAndPerfTestWebKit2
Raphael Kubo da Costa (:rakuco)
Comment 5 2013-02-07 07:34:40 PST
Created attachment 187106 [details] Patch for landing
Raphael Kubo da Costa (:rakuco)
Comment 6 2013-02-07 07:37:14 PST
Committed r142121: <http://trac.webkit.org/changeset/142121>
Csaba Osztrogonác
Comment 7 2013-02-07 08:31:12 PST
Comment on attachment 187106 [details] Patch for landing View in context: https://bugs.webkit.org/attachment.cgi?id=187106&action=review > Tools/BuildSlaveSupport/build.webkit.org-config/config.json:440 > + { "type": "Triggerable", "name": "efl-linux-64-release-wk2-perf", > + "builderNames": ["EFL Linux 64-bit Release WK2 (Perf)"] typo: s/efl-linux-64-release-wk2-perf/efl-linux-perf-1
Csaba Osztrogonác
Comment 8 2013-02-07 08:34:08 PST
Comment on attachment 187106 [details] Patch for landing View in context: https://bugs.webkit.org/attachment.cgi?id=187106&action=review > Tools/BuildSlaveSupport/build.webkit.org-config/config.json:336 > + "triggers": ["efl-linux-perf-1"], I was wrong. The typo is here. It should be: "triggers": ["efl-linux-64-release-wk2-perf"] Because we don't trigger the builder itself, but the triggerable scheduler which has this name.
Csaba Osztrogonác
Comment 9 2013-02-07 08:51:06 PST
Fix landed in https://trac.webkit.org/changeset/142133
Ryosuke Niwa
Comment 10 2013-02-08 21:08:32 PST
See 109342.
Note You need to log in before you can comment on or make changes to this bug.