Bug 109186

Summary: [V8] Move V8DOMWrapper::setNamedHiddenReference() to V8HiddenPropertyName.h
Product: WebKit Reporter: Kentaro Hara <haraken>
Component: WebCore JavaScriptAssignee: Kentaro Hara <haraken>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, japhet, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
patch for landing
none
patch for landing none

Description Kentaro Hara 2013-02-07 06:11:03 PST 
Move V8DOMWrapper::setNamedHiddenReference() to V8HiddenPropertyName.h.
Comment 1 Kentaro Hara 2013-02-07 06:13:16 PST 
Created attachment 187085 [details]
Patch
Comment 2 Adam Barth 2013-02-07 11:09:58 PST 
Comment on attachment 187085 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=187085&action=review

> Source/WebCore/bindings/v8/V8HiddenPropertyName.cpp:77
> +    parent->SetHiddenValue(V8HiddenPropertyName::hiddenReferenceName(name, strlen(name)), child);

The "V8HiddenPropertyName::" probably isn't needed any more.
Comment 3 Kentaro Hara 2013-02-07 17:12:54 PST 
Created attachment 187202 [details]
patch for landing
Comment 4 Kentaro Hara 2013-02-07 17:14:06 PST 
(In reply to comment #2)
> (From update of attachment 187085 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=187085&action=review
> 
> > Source/WebCore/bindings/v8/V8HiddenPropertyName.cpp:77
> > +    parent->SetHiddenValue(V8HiddenPropertyName::hiddenReferenceName(name, strlen(name)), child);
> 
> The "V8HiddenPropertyName::" probably isn't needed any more.

Yeah, given that hiddenReferenceName() is called from V8HiddenPropertyName.cpp only, I made the method static.
Comment 5 Kentaro Hara 2013-02-07 17:19:33 PST 
Created attachment 187203 [details]
patch for landing
Comment 6 WebKit Review Bot 2013-02-07 18:12:39 PST 
Comment on attachment 187203 [details]
patch for landing

Clearing flags on attachment: 187203

Committed r142217: <http://trac.webkit.org/changeset/142217>
Comment 7 WebKit Review Bot 2013-02-07 18:12:43 PST 
All reviewed patches have been landed.  Closing bug.