Bug 109186

Summary: [V8] Move V8DOMWrapper::setNamedHiddenReference() to V8HiddenPropertyName.h
Product: WebKit Reporter: Kentaro Hara <haraken>
Component: WebCore JavaScriptAssignee: Kentaro Hara <haraken>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, japhet, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
patch for landing
none
patch for landing none

Kentaro Hara
Reported 2013-02-07 06:11:03 PST
Move V8DOMWrapper::setNamedHiddenReference() to V8HiddenPropertyName.h.
Attachments
Patch (9.44 KB, patch)
2013-02-07 06:13 PST, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
patch for landing (9.79 KB, patch)
2013-02-07 17:12 PST, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
patch for landing (9.85 KB, patch)
2013-02-07 17:19 PST, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Kentaro Hara
Comment 1 2013-02-07 06:13:16 PST
Created attachment 187085 [details] Patch
Adam Barth
Comment 2 2013-02-07 11:09:58 PST
Comment on attachment 187085 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=187085&action=review > Source/WebCore/bindings/v8/V8HiddenPropertyName.cpp:77 > + parent->SetHiddenValue(V8HiddenPropertyName::hiddenReferenceName(name, strlen(name)), child); The "V8HiddenPropertyName::" probably isn't needed any more.
Kentaro Hara
Comment 3 2013-02-07 17:12:54 PST
Created attachment 187202 [details] patch for landing
Kentaro Hara
Comment 4 2013-02-07 17:14:06 PST
(In reply to comment #2) > (From update of attachment 187085 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=187085&action=review > > > Source/WebCore/bindings/v8/V8HiddenPropertyName.cpp:77 > > + parent->SetHiddenValue(V8HiddenPropertyName::hiddenReferenceName(name, strlen(name)), child); > > The "V8HiddenPropertyName::" probably isn't needed any more. Yeah, given that hiddenReferenceName() is called from V8HiddenPropertyName.cpp only, I made the method static.
Kentaro Hara
Comment 5 2013-02-07 17:19:33 PST
Created attachment 187203 [details] patch for landing
WebKit Review Bot
Comment 6 2013-02-07 18:12:39 PST
Comment on attachment 187203 [details] patch for landing Clearing flags on attachment: 187203 Committed r142217: <http://trac.webkit.org/changeset/142217>
WebKit Review Bot
Comment 7 2013-02-07 18:12:43 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.