Bug 109172

Summary:

Implement drawFocusRing(const Vector<IntRect>& rects, int width, int offset, const Color& color) in GraphicsContextSkia

Product:

WebKit

Reporter:

Changhun Kang <chkang514>

Component:

Canvas

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED WONTFIX

Severity:

Normal

CC:

caryclark, darin, dglazkov, eric, junov, peter+ews, senorblanco, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	webkit.review.bot: commit-queue-
Patch	webkit.review.bot: commit-queue-

Changhun Kang

Reported 2013-02-07 03:49:26 PST

Implement void GraphicsContext::drawFocusRing(const Vector<IntRect>& rects, int width, int offset, const Color& color).

Attachments
Patch (2.27 KB, patch) 2013-02-07 03:58 PST, Changhun Kang	webkit.review.bot: commit-queue-	Details Formatted Diff Diff
Patch (2.65 KB, patch) 2013-02-07 22:52 PST, Changhun Kang	webkit.review.bot: commit-queue-	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Changhun Kang

Comment 1 2013-02-07 03:58:46 PST

Created attachment 187049 [details] Patch This is a WIP patch. I refer to the implementation of Qt. Give me any advice. Thanks

WebKit Review Bot

Comment 2 2013-02-07 05:33:09 PST

Comment on attachment 187049 [details] Patch Attachment 187049 [details] did not pass cr-linux-debug-ews (chromium-xvfb): Output: http://queues.webkit.org/results/16415245

Peter Beverloo (cr-android ews)

Comment 3 2013-02-07 05:34:34 PST

Comment on attachment 187049 [details] Patch Attachment 187049 [details] did not pass cr-android-ews (chromium-android): Output: http://queues.webkit.org/results/16429130

WebKit Review Bot

Comment 4 2013-02-07 09:46:34 PST

Comment on attachment 187049 [details] Patch Attachment 187049 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/16429218

Changhun Kang

Comment 5 2013-02-07 22:52:38 PST

Created attachment 187240 [details] Patch Build Fix.

WebKit Review Bot

Comment 6 2013-02-07 23:20:52 PST

Comment on attachment 187240 [details] Patch Attachment 187240 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/16426535

WebKit Review Bot

Comment 7 2013-02-07 23:22:14 PST

Comment on attachment 187240 [details] Patch Attachment 187240 [details] did not pass cr-linux-debug-ews (chromium-xvfb): Output: http://queues.webkit.org/results/16415625

Peter Beverloo (cr-android ews)

Comment 8 2013-02-07 23:38:05 PST

Comment on attachment 187240 [details] Patch Attachment 187240 [details] did not pass cr-android-ews (chromium-android): Output: http://queues.webkit.org/results/16435500

Darin Adler

Comment 9 2013-04-09 09:39:04 PDT

Comment on attachment 187240 [details] Patch Clearing flags on Skia-specific patch.

Note You need to log in before you can comment on or make changes to this bug.