Bug 109123

Summary:

[V8] StringCache::m_stringCache should be HashMap<StringImpl*, Persistent<String>>

Product:

WebKit

Reporter:

Kentaro Hara <haraken>

Component:

WebCore JavaScript

Assignee:

Kentaro Hara <haraken>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, japhet, jsbell, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Kentaro Hara

Reported 2013-02-06 18:15:05 PST

Currently StringCache::m_stringCache is implemented as HashMap<StringImpl*, v8::String*>. Given that v8::String* can change when a GC is triggered, this is dangerous. We should use HashMap<StringImpl*, v8::Persistent<v8::String>> instead.

Attachments
Patch (3.81 KB, patch) 2013-02-06 18:20 PST, Kentaro Hara	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Kentaro Hara

Comment 1 2013-02-06 18:20:28 PST

Created attachment 186971 [details] Patch

WebKit Review Bot

Comment 2 2013-02-07 10:58:46 PST

Comment on attachment 186971 [details] Patch Clearing flags on attachment: 186971 Committed r142154: <http://trac.webkit.org/changeset/142154>

WebKit Review Bot

Comment 3 2013-02-07 10:58:49 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.