Bug 109123

Summary: [V8] StringCache::m_stringCache should be HashMap<StringImpl*, Persistent<String>>
Product: WebKit Reporter: Kentaro Hara <haraken>
Component: WebCore JavaScriptAssignee: Kentaro Hara <haraken>
Severity: Normal CC: abarth, japhet, jsbell, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Description Flags
Patch none

Description Kentaro Hara 2013-02-06 18:15:05 PST
Currently StringCache::m_stringCache is implemented as HashMap<StringImpl*, v8::String*>. Given that v8::String* can change when a GC is triggered, this is dangerous. We should use HashMap<StringImpl*, v8::Persistent<v8::String>> instead.
Comment 1 Kentaro Hara 2013-02-06 18:20:28 PST
Created attachment 186971 [details]
Comment 2 WebKit Review Bot 2013-02-07 10:58:46 PST
Comment on attachment 186971 [details]

Clearing flags on attachment: 186971

Committed r142154: <http://trac.webkit.org/changeset/142154>
Comment 3 WebKit Review Bot 2013-02-07 10:58:49 PST
All reviewed patches have been landed.  Closing bug.