Bug 109123 - [V8] StringCache::m_stringCache should be HashMap<StringImpl*, Persistent<String>>
Summary: [V8] StringCache::m_stringCache should be HashMap<StringImpl*, Persistent<Str...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kentaro Hara
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-06 18:15 PST by Kentaro Hara
Modified: 2013-02-07 10:58 PST (History)
4 users (show)

See Also:


Attachments
Patch (3.81 KB, patch)
2013-02-06 18:20 PST, Kentaro Hara
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kentaro Hara 2013-02-06 18:15:05 PST
Currently StringCache::m_stringCache is implemented as HashMap<StringImpl*, v8::String*>. Given that v8::String* can change when a GC is triggered, this is dangerous. We should use HashMap<StringImpl*, v8::Persistent<v8::String>> instead.
Comment 1 Kentaro Hara 2013-02-06 18:20:28 PST
Created attachment 186971 [details]
Patch
Comment 2 WebKit Review Bot 2013-02-07 10:58:46 PST
Comment on attachment 186971 [details]
Patch

Clearing flags on attachment: 186971

Committed r142154: <http://trac.webkit.org/changeset/142154>
Comment 3 WebKit Review Bot 2013-02-07 10:58:49 PST
All reviewed patches have been landed.  Closing bug.