Bug 10912
| Summary: | run-webkit-tests has become an unmaintainable ball of perl snot | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Eric Seidel (no email) <eric> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED INVALID | ||
| Severity: | Normal | CC: | ap, ddkilzer, sam |
| Priority: | P4 | ||
| Version: | 420+ | ||
| Hardware: | Mac | ||
| OS: | OS X 10.4 | ||
| Bug Depends on: | |||
| Bug Blocks: | 10906 | ||
Eric Seidel (no email)
run-webkit-tests needs some serious re-factoring. I looked briefly at solving bug 10906 this evening, but quickly gave up. run-webkit-tests may need to move away from Perl entirely, as perl's lack of real class support is a serious limitation, causing overly awkward code.
My suggestion would be that a pair of people work together to commit small incremental improvements (mostly breaking everything out into subroutines) in rapid succession, with a review on each improvement.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Eric Seidel (no email)
This bug isn't actually very useful, and probably should just be closed. The fact remains though, run-webkit-tests is uggggly.
Alexey Proskuryakov
Closing per the above comment.
Personally, I haven't heard of people having much trouble hacking run-webkit-tests, aside from bug 10906, which isn't quite trivial conceptually, anyway.