Bug 10912 - run-webkit-tests has become an unmaintainable ball of perl snot
Summary: run-webkit-tests has become an unmaintainable ball of perl snot
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 420+
Hardware: Macintosh OS X 10.4
: P4 Normal
Assignee: Nobody
Depends on:
Blocks: 10906
  Show dependency treegraph
Reported: 2006-09-18 01:53 PDT by Eric Seidel (no email)
Modified: 2007-10-18 02:28 PDT (History)
3 users (show)

See Also:


Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2006-09-18 01:53:06 PDT
run-webkit-tests needs some serious re-factoring.  I looked briefly at solving bug 10906 this evening, but quickly gave up.  run-webkit-tests may need to move away from Perl entirely, as perl's lack of real class support is a serious limitation, causing overly awkward code.

My suggestion would be that a pair of people work together to commit small incremental improvements (mostly breaking everything out into subroutines) in rapid succession, with a review on each improvement.
Comment 1 Eric Seidel (no email) 2007-10-18 01:03:56 PDT
This bug isn't actually very useful, and probably should just be closed.  The fact remains though, run-webkit-tests is uggggly.
Comment 2 Alexey Proskuryakov 2007-10-18 02:28:07 PDT
Closing per the above comment.

Personally, I haven't heard of people having much trouble hacking run-webkit-tests, aside from bug 10906, which isn't quite trivial conceptually, anyway.