Bug 109101

Summary: Reset the border property for -webkit-slider-thumb in unknown-pseudo-element-matching test
Product: WebKit Reporter: Dima Gorbik <dgorbik>
Component: Tools / TestsAssignee: Dima Gorbik <dgorbik>
Status: RESOLVED FIXED    
Severity: Normal CC: ddkilzer, joepeck, webkit-bug-importer, webkit.review.bot
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Proposed fix 0.1
joepeck: review+
Proposed fix 0.2 none

Description Dima Gorbik 2013-02-06 15:29:34 PST
We check that the style matches a pseudo element by setting its height to 1px. But if there was a border property set in default styles the minimum height will be 2px, so the test will fail. We need to reset this property.
Comment 1 Radar WebKit Bug Importer 2013-02-06 15:29:45 PST
<rdar://problem/13166872>
Comment 2 Dima Gorbik 2013-02-06 15:36:19 PST
Created attachment 186935 [details]
Proposed fix 0.1
Comment 3 Joseph Pecoraro 2013-02-06 15:38:40 PST
Comment on attachment 186935 [details]
Proposed fix 0.1

View in context: https://bugs.webkit.org/attachment.cgi?id=186935&action=review

r=me

> LayoutTests/ChangeLog:8
> +        We need to reset this property.

You could call out a sample user agent "Some user agents, like iOS, have default border styles that affect the minimum height".
Comment 4 Dima Gorbik 2013-02-06 15:42:12 PST
Created attachment 186937 [details]
Proposed fix 0.2
Comment 5 Joseph Pecoraro 2013-02-06 15:43:27 PST
Comment on attachment 186937 [details]
Proposed fix 0.2

r=me
Comment 6 WebKit Review Bot 2013-02-06 16:32:52 PST
Comment on attachment 186937 [details]
Proposed fix 0.2

Clearing flags on attachment: 186937

Committed r142052: <http://trac.webkit.org/changeset/142052>
Comment 7 WebKit Review Bot 2013-02-06 16:32:56 PST
All reviewed patches have been landed.  Closing bug.