Bug 109079

Summary: [Text Autosizing] Cleanup change: converted the pointer argument to be a reference since non-null pointer is always expected
Product: WebKit Reporter: Anton Vayvod <avayvod>
Component: Layout and RenderingAssignee: Anton Vayvod <avayvod>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, jchaffraix, johnme, kenneth, ojan.autocc, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Android   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Anton Vayvod
Reported 2013-02-06 11:32:09 PST
[Text Autosizing] Cleanup change: converter the pointer argument to be a reference since non-null pointer is always expected
Attachments
Patch (11.21 KB, patch)
2013-02-06 11:34 PST, Anton Vayvod 		no flags
DetailsFormatted DiffDiff
Patch (11.86 KB, patch)
2013-02-08 12:24 PST, Anton Vayvod 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Anton Vayvod
Comment 1 2013-02-06 11:34:46 PST
Created attachment 186884 [details] Patch
Julien Chaffraix
Comment 2 2013-02-06 11:48:26 PST
Comment on attachment 186884 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=186884&action=review > Source/WebCore/rendering/TextAutosizer.cpp:298 > TextAutosizingClusterInfo emptyClusterInfo(0); > - return isAutosizingContainer(object) && isAutosizingCluster(toRenderBlock(object), &emptyClusterInfo); > + return isAutosizingContainer(object) && isAutosizingCluster(toRenderBlock(object), emptyClusterInfo); Mentioned on bug 109054, I would rather see isAutosizingCluster take a pointer that can be NULL instead of having an empty object. That would remove the need for this overriden method.
Build Bot
Comment 3 2013-02-06 15:55:53 PST
Comment on attachment 186884 [details] Patch Attachment 186884 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/16387485
Anton Vayvod
Comment 4 2013-02-08 12:24:31 PST
Created attachment 187347 [details] Patch
WebKit Review Bot
Comment 5 2013-02-09 10:35:39 PST
Comment on attachment 187347 [details] Patch Clearing flags on attachment: 187347 Committed r142367: <http://trac.webkit.org/changeset/142367>
WebKit Review Bot
Comment 6 2013-02-09 10:35:43 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.