Bug 109072

Summary: IndexedDB: De-flake open-during-transaction layout test
Product: WebKit Reporter: Joshua Bell <jsbell>
Component: New BugsAssignee: Joshua Bell <jsbell>
Status: RESOLVED FIXED    
Severity: Normal CC: alecflett, dgrogan, tony, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Joshua Bell
Reported 2013-02-06 11:05:48 PST
IndexedDB: De-flake open-during-transaction layout test
Attachments
Patch (4.05 KB, patch)
2013-02-06 11:10 PST, Joshua Bell 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Joshua Bell
Comment 1 2013-02-06 11:10:17 PST
Created attachment 186879 [details] Patch
Joshua Bell
Comment 2 2013-02-06 11:18:37 PST
dgrogan@, alecflett@ - can you take a look? I saw this flake when doing repeated runs of the storage/indexeddb tests. I was actually surprised to see this flake under DRT (single-process) as opposed to content_shell (multi-process), but I believe it's due to the timing of the open() calls occurring in event callbacks vs. the transaction timer. (I also moved my /tmp dir to a ramdisk so the opens() take less wall-clock time on my machine.) I don't know if it's worth digging in further. The test was first added in wkrev.com/98749 to act as a canary for crashes around with metadata snapshotting. Since then that whole mechanism has changed and there are dedicated tests and setVersion() has been removed. So I think the remaining purpose of this test is merely "make sure open()-with-no-version isn't blocked on a running transaction". This seems trivial but weird, so feedback appreciated.
Alec Flett
Comment 3 2013-02-06 14:22:53 PST
lgtm
David Grogan
Comment 4 2013-02-06 17:39:56 PST
lgtm2
Joshua Bell
Comment 5 2013-02-08 14:39:18 PST
tony@ - when convenient, r? cq?
WebKit Review Bot
Comment 6 2013-02-08 14:50:23 PST
Comment on attachment 186879 [details] Patch Clearing flags on attachment: 186879 Committed r142324: <http://trac.webkit.org/changeset/142324>
WebKit Review Bot
Comment 7 2013-02-08 14:50:26 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.