Bug 109042

Summary:

Web Inspector: Native Memory Instrumentation: provide name property for DOM Element and Attribute nodes.

Product:

WebKit

Reporter:

Ilya Tikhonovsky <loislo>

Component:

Web Inspector (Deprecated)

Assignee:

Ilya Tikhonovsky <loislo>

Status:

RESOLVED WONTFIX

Severity:

Normal

CC:

apavlov, cmarcelo, keishi, loislo, ojan.autocc, pfeldman, pmuellr, vsevik, web-inspector-bugs, webkit.review.bot, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

107254

Attachments:

Description	Flags
Patch	none

Description Ilya Tikhonovsky 2013-02-06 05:21:54 PST

EOM

Comment 1 Ilya Tikhonovsky 2013-02-06 05:28:54 PST

Created attachment 186836 [details]
Patch

Comment 2 Yury Semikhatsky 2013-02-08 00:22:47 PST

Comment on attachment 186836 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=186836&action=review

> Source/WebCore/dom/Element.cpp:2827
> +    memoryObjectInfo->setName(buildElementSelectorString(this).utf8().data());

This may have a noticeable performance impact which should be avoided in the cases when we don't collect heap graph.

Comment 3 Pavel Feldman 2013-03-19 09:53:39 PDT

Comment on attachment 186836 [details]
Patch

Clearing r? - it has been there for ages, probably obsolete.