Bug 109008

Summary: AX: if <html> has an ARIA attribute, it's exposed as an AXGroup
Product: WebKit Reporter: chris fleizach <cfleizach>
Component: AccessibilityAssignee: chris fleizach <cfleizach>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, apinheiro, dglazkov, dmazzoni, jdiggs, rniwa, webkit.review.bot
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
rniwa: review+, webkit.review.bot: commit-queue-
patch for landing none

chris fleizach
Reported 2013-02-05 22:38:42 PST
If you do <html aria-label="test"> then the <html> element becomes an AXGroup in the AX hierarchy. We should not be exposing the <html> element because it adds another layer in the AX hierarchy for no reason, and can confuse screen readers
Attachments
patch (4.43 KB, patch)
2013-02-05 23:07 PST, chris fleizach 		rniwa: review+
webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
patch for landing (5.56 KB, patch)
2013-02-06 11:38 PST, chris fleizach 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
chris fleizach
Comment 1 2013-02-05 22:38:55 PST
rdar://13130243
chris fleizach
Comment 2 2013-02-05 23:07:52 PST
Created attachment 186763 [details] patch
Ryosuke Niwa
Comment 3 2013-02-06 01:14:20 PST
Comment on attachment 186763 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=186763&action=review > Source/WebCore/accessibility/AccessibilityRenderObject.cpp:2592 > + Nit: spaces. > LayoutTests/accessibility/html-html-element-is-ignored.html:20 > + } It would have been helpful if you printed a message like debug("This test requires accessibilityController"); so that a person who opened this file manually on a browser can tell why the test is not running.
WebKit Review Bot
Comment 4 2013-02-06 01:23:05 PST
Comment on attachment 186763 [details] patch Attachment 186763 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/16378990 New failing tests: accessibility/html-html-element-is-ignored.html
WebKit Review Bot
Comment 5 2013-02-06 02:21:58 PST
Comment on attachment 186763 [details] patch Attachment 186763 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/16389170 New failing tests: accessibility/html-html-element-is-ignored.html
chris fleizach
Comment 6 2013-02-06 08:04:31 PST
(In reply to comment #5) > (From update of attachment 186763 [details]) > Attachment 186763 [details] did not pass chromium-ews (chromium-xvfb): > Output: http://queues.webkit.org/results/16389170 > > New failing tests: > accessibility/html-html-element-is-ignored.html chromium has a different element besides a web area I think, so I'll skip this test for cr for now
chris fleizach
Comment 7 2013-02-06 08:35:54 PST
(In reply to comment #3) > (From update of attachment 186763 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=186763&action=review > > > Source/WebCore/accessibility/AccessibilityRenderObject.cpp:2592 > > + > > Nit: spaces. > > > LayoutTests/accessibility/html-html-element-is-ignored.html:20 > > + } > > It would have been helpful if you printed a message like debug("This test requires accessibilityController"); so that a person who opened this file manually on a browser can tell why the test is not running. done and done. thanks
chris fleizach
Comment 8 2013-02-06 11:38:09 PST
Created attachment 186886 [details] patch for landing
chris fleizach
Comment 9 2013-02-06 12:10:36 PST
http://trac.webkit.org/changeset/142014
Note You need to log in before you can comment on or make changes to this bug.