Summary: | [BlackBerry] Export mimeType in NetworkJob | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Mary Wu <mawu> | ||||||||
Component: | Platform | Assignee: | Mary Wu <mawu> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | lquinn, mifenton, rwlbuis, tonikitoo, webkit.review.bot, yong.li.webkit | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Mary Wu
2013-02-05 20:13:42 PST
Created attachment 186750 [details]
Patch
Created attachment 186806 [details]
Patch
Comment on attachment 186806 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=186806&action=review > Source/WebCore/platform/network/blackberry/NetworkJob.cpp:958 > +const BlackBerry::Platform::String NetworkJob::mimeType() const > +{ > + String type = m_response.mimeType(); > + > + return type.isEmpty() ? "" : type.utf8().data(); > +} Why do we have to use utf8()? This always creates a new CString (In reply to comment #3) > (From update of attachment 186806 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=186806&action=review > > > Source/WebCore/platform/network/blackberry/NetworkJob.cpp:958 > > +const BlackBerry::Platform::String NetworkJob::mimeType() const > > +{ > > + String type = m_response.mimeType(); > > + > > + return type.isEmpty() ? "" : type.utf8().data(); > > +} > > Why do we have to use utf8()? This always creates a new CString nice, looks we already implemented that in StringBlackBerry. thanks Created attachment 186977 [details]
Patch
Comment on attachment 186977 [details] Patch Clearing flags on attachment: 186977 Committed r142115: <http://trac.webkit.org/changeset/142115> All reviewed patches have been landed. Closing bug. |