Summary: | [chromium] Explicitly destroy the WebMediaPlayer in WebMediaPlayerClientImpl's destructor | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | David Dorwin <ddorwin> | ||||||
Component: | Media | Assignee: | David Dorwin <ddorwin> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | eric.carlson, feature-media-reviews, scherkus, tkent, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
David Dorwin
2013-02-05 16:15:33 PST
Created attachment 186722 [details]
Patch
scherkus says LGTM, but I need an R+. Comment on attachment 186722 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=186722&action=review > Source/WebKit/chromium/src/WebMediaPlayerClientImpl.cpp:112 > + // TODO(ddorwin): Uncomment the assert and remove the closeHelperPlugin() TODO() -> FIXME Created attachment 186727 [details]
Patch
Comment on attachment 186722 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=186722&action=review >> Source/WebKit/chromium/src/WebMediaPlayerClientImpl.cpp:112 >> + // TODO(ddorwin): Uncomment the assert and remove the closeHelperPlugin() > > TODO() -> FIXME Done. Comment on attachment 186727 [details]
Patch
ok
Comment on attachment 186727 [details] Patch Clearing flags on attachment: 186727 Committed r141954: <http://trac.webkit.org/changeset/141954> All reviewed patches have been landed. Closing bug. |