Bug 108989

Summary: [chromium] Explicitly destroy the WebMediaPlayer in WebMediaPlayerClientImpl's destructor
Product: WebKit Reporter: David Dorwin <ddorwin>
Component: MediaAssignee: David Dorwin <ddorwin>
Status: RESOLVED FIXED    
Severity: Normal CC: eric.carlson, feature-media-reviews, scherkus, tkent, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

David Dorwin
Reported 2013-02-05 16:15:33 PST
[chromium] Explicitly destroy the WebMediaPlayer in WebMediaPlayerClientImpl's destructor
Attachments
Patch (1.90 KB, patch)
2013-02-05 16:18 PST, David Dorwin 		no flags
DetailsFormatted DiffDiff
Patch (1.90 KB, patch)
2013-02-05 17:12 PST, David Dorwin 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
David Dorwin
Comment 1 2013-02-05 16:18:03 PST
Created attachment 186722 [details] Patch
David Dorwin
Comment 2 2013-02-05 16:24:14 PST
scherkus says LGTM, but I need an R+.
Kent Tamura
Comment 3 2013-02-05 17:06:36 PST
Comment on attachment 186722 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=186722&action=review > Source/WebKit/chromium/src/WebMediaPlayerClientImpl.cpp:112 > + // TODO(ddorwin): Uncomment the assert and remove the closeHelperPlugin() TODO() -> FIXME
David Dorwin
Comment 4 2013-02-05 17:12:02 PST
Created attachment 186727 [details] Patch
David Dorwin
Comment 5 2013-02-05 17:12:34 PST
Comment on attachment 186722 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=186722&action=review >> Source/WebKit/chromium/src/WebMediaPlayerClientImpl.cpp:112 >> + // TODO(ddorwin): Uncomment the assert and remove the closeHelperPlugin() > > TODO() -> FIXME Done.
Kent Tamura
Comment 6 2013-02-05 17:19:04 PST
Comment on attachment 186727 [details] Patch ok
WebKit Review Bot
Comment 7 2013-02-05 17:43:43 PST
Comment on attachment 186727 [details] Patch Clearing flags on attachment: 186727 Committed r141954: <http://trac.webkit.org/changeset/141954>
WebKit Review Bot
Comment 8 2013-02-05 17:43:46 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.