Bug 108966

Summary: [chromium] Remove "config.h" header from WebUnitTests.cpp
Product: WebKit Reporter: Daniel Cheng <dcheng>
Component: PlatformAssignee: Daniel Cheng <dcheng>
Status: RESOLVED FIXED    
Severity: Normal CC: fishd
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch tony: review+

Daniel Cheng
Reported 2013-02-05 12:03:41 PST
WebUnitTests.cpp is an intentional layering violation and includes some headers from base/ in the Chromium code. "config.h" is largely unneeded (it was used for ASSERT, and attempting to run a null test suite isn't going to get very far anyway) and conflicted with base/logging.h, so it'd be nice to remove it rather than teach certain files not to #include base/logging.h.
Attachments
Patch (1.69 KB, patch)
2013-02-05 12:07 PST, Daniel Cheng 		tony: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Daniel Cheng
Comment 1 2013-02-05 12:07:12 PST
Created attachment 186671 [details] Patch
Tony Chang
Comment 2 2013-02-06 13:24:25 PST
Comment on attachment 186671 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=186671&action=review > Source/WebKit/chromium/tests/WebUnitTests.cpp:33 > #include <base/test/test_suite.h> Please add a FIXME about this include since it's a layering violation.
Daniel Cheng
Comment 3 2013-02-06 13:37:26 PST
Committed r142027: <http://trac.webkit.org/changeset/142027>
Note You need to log in before you can comment on or make changes to this bug.