Bug 108959 – [WEBGL] Rename WEBKIT_WEBGL_depth_texture to WEBGL_depth_texture.

• Component: WebGL
• Status: RESOLVED FIXED

[Nayan Kumar K]

WEBGL_depth_texture is official now - http://www.khronos.org/registry/webgl/extensions/WEBGL_depth_texture/. Hence remove the support for vendor prefix of extension string.

[Nayan Kumar K]

Created attachment 186662 [details]
Patch

[Kenneth Russell]

Comment on attachment 186662 [details]
Patch

Looks fine. Please submit a pull request to the Khronos repository with the change to the conformance test. Thanks.

[WebKit Review Bot]

Comment on attachment 186662 [details]
Patch

Clearing flags on attachment: 186662

Committed r141922: <http://trac.webkit.org/changeset/141922>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Nayan Kumar K]

(In reply to comment #2)
> (From update of attachment 186662 [details])
> Looks fine. Please submit a pull request to the Khronos repository with the change to the conformance test. Thanks.

WebGL conformance tests uses "getExtensionWithKnownPrefixes" function as extension name look-up. This look-up already covers non-prefix'ed version of string, hence I think it needs no modification.

[Kenneth Russell]

(In reply to comment #5)
> (In reply to comment #2)
> > (From update of attachment 186662 [details] [details])
> > Looks fine. Please submit a pull request to the Khronos repository with the change to the conformance test. Thanks.
> 
> WebGL conformance tests uses "getExtensionWithKnownPrefixes" function as extension name look-up. This look-up already covers non-prefix'ed version of string, hence I think it needs no modification.

I see. OK.

[Nayan Kumar K]

> 
> I see. OK.

As a side note, instead of maintaining subset of WebGL conformance tests in LayoutTests/fast/canvas/webgl, shouldn't we try to
a. Let build bots run conformance tests run directly from Khronos WebGL repository? This method deviates from existing test framework (as the tests are maintained outside WebKit repository), but avoids maintaining similar tests in 2 places.
b. Pull-in whole of Khronos WebGL conformance tests into LayoutTests and keep them in sync at regular intervals?

Above alternatives may require us to write some sort of filters to filter out executing subset of tests (which are not applicable or which fails). Just a thought, let me know your opinion.

[Kenneth Russell]

(In reply to comment #7)
> > 
> > I see. OK.
> 
> As a side note, instead of maintaining subset of WebGL conformance tests in LayoutTests/fast/canvas/webgl, shouldn't we try to
> a. Let build bots run conformance tests run directly from Khronos WebGL repository? This method deviates from existing test framework (as the tests are maintained outside WebKit repository), but avoids maintaining similar tests in 2 places.
> b. Pull-in whole of Khronos WebGL conformance tests into LayoutTests and keep them in sync at regular intervals?
> 
> Above alternatives may require us to write some sort of filters to filter out executing subset of tests (which are not applicable or which fails). Just a thought, let me know your opinion.

Gregg Tavares is incorporating the entire Khronos WebGL conformance suite as layout tests. Follow https://bugs.webkit.org/show_bug.cgi?id=94643 and related bugs for progress.

[Nayan Kumar K]

> 
> Gregg Tavares is incorporating the entire Khronos WebGL conformance suite as layout tests. Follow https://bugs.webkit.org/show_bug.cgi?id=94643 and related bugs for progress.

Great. Thanks.