Bug 108948

Summary: Add a performance test for arabic line breaking
Product: WebKit Reporter: Dominik Röttsches (drott) <d-r>
Component: Tools / TestsAssignee: Dominik Röttsches (drott) <d-r>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, dpranke, eric, rniwa, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch, v2 - Skipping. none

Description Dominik Röttsches (drott) 2013-02-05 08:25:23 PST
Adding an arabic line breaking perfomance text to exercise the complex font path.
Text source is the arabic version of One Thousand and One Nights
http://ar.wikisource.org/wiki/%D8%A3%D9%84%D9%81_%D9%84%D9%8A%D9%84%D8%A9_%D9%88%D9%84%D9%8A%D9%84%D8%A9/%D8%A7%D9%84%D8%AC%D8%B2%D8%A1_%D8%A7%D9%84%D8%A3%D9%88%D9%84
which according to all I could find out is in the public domain.
Comment 1 Chris Dumez 2013-02-05 08:33:14 PST
do you mean "text" or "test"?
Comment 2 Dominik Röttsches (drott) 2013-02-05 08:35:46 PST
Created attachment 186630 [details]
Patch
Comment 3 Dominik Röttsches (drott) 2013-02-05 08:37:09 PST
(In reply to comment #1)
> do you mean "text" or "test"?

Test, sry.
Comment 4 Dominik Röttsches (drott) 2013-02-05 08:37:50 PST
Created attachment 186631 [details]
Patch
Comment 5 Eric Seidel (no email) 2013-02-05 09:42:35 PST
Comment on attachment 186631 [details]
Patch

So this is going to include the creation of the rendering tree from scratch, is that what you intented?
Comment 6 Dominik Röttsches (drott) 2013-02-05 10:29:16 PST
(In reply to comment #5)
> (From update of attachment 186631 [details])
> So this is going to include the creation of the rendering tree from scratch, is that what you intented?

Yes, my intention was to get the width measurement of the complex font path measured. As far as I understand, creating the render tree initially does this in a similar way as a reflow.
Comment 7 Ryosuke Niwa 2013-02-05 10:30:49 PST
Comment on attachment 186631 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=186631&action=review

> PerformanceTests/ChangeLog:11
> +        * Layout/arabic-line-layout.html: Added.

Please skip this test by default.
Comment 8 Ryosuke Niwa 2013-02-05 10:31:36 PST
Also, please use CamelCase.
Comment 9 Ryosuke Niwa 2013-02-05 10:32:00 PST
(In reply to comment #8)
> Also, please use CamelCase.

for the file name.
Comment 10 Dominik Röttsches (drott) 2013-02-05 10:57:46 PST
Created attachment 186660 [details]
Patch, v2 - Skipping.
Comment 11 WebKit Review Bot 2013-02-05 11:17:33 PST
Comment on attachment 186660 [details]
Patch, v2 - Skipping.

Clearing flags on attachment: 186660

Committed r141906: <http://trac.webkit.org/changeset/141906>
Comment 12 WebKit Review Bot 2013-02-05 11:17:37 PST
All reviewed patches have been landed.  Closing bug.