Summary: | Add a performance test for arabic line breaking | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Dominik Röttsches (drott) <d-r> | ||||||||
Component: | Tools / Tests | Assignee: | Dominik Röttsches (drott) <d-r> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | cdumez, dpranke, eric, rniwa, webkit.review.bot | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Dominik Röttsches (drott)
2013-02-05 08:25:23 PST
do you mean "text" or "test"? Created attachment 186630 [details]
Patch
(In reply to comment #1) > do you mean "text" or "test"? Test, sry. Created attachment 186631 [details]
Patch
Comment on attachment 186631 [details]
Patch
So this is going to include the creation of the rendering tree from scratch, is that what you intented?
(In reply to comment #5) > (From update of attachment 186631 [details]) > So this is going to include the creation of the rendering tree from scratch, is that what you intented? Yes, my intention was to get the width measurement of the complex font path measured. As far as I understand, creating the render tree initially does this in a similar way as a reflow. Comment on attachment 186631 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=186631&action=review > PerformanceTests/ChangeLog:11 > + * Layout/arabic-line-layout.html: Added. Please skip this test by default. Also, please use CamelCase. (In reply to comment #8) > Also, please use CamelCase. for the file name. Created attachment 186660 [details]
Patch, v2 - Skipping.
Comment on attachment 186660 [details] Patch, v2 - Skipping. Clearing flags on attachment: 186660 Committed r141906: <http://trac.webkit.org/changeset/141906> All reviewed patches have been landed. Closing bug. |