Bug 108948

Summary:

Add a performance test for arabic line breaking

Product:

WebKit

Reporter:

Dominik Röttsches (drott) <d-r>

Component:

Tools / Tests

Assignee:

Dominik Röttsches (drott) <d-r>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, dpranke, eric, rniwa, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch, v2 - Skipping.	none

Dominik Röttsches (drott)

Reported 2013-02-05 08:25:23 PST

Adding an arabic line breaking perfomance text to exercise the complex font path. Text source is the arabic version of One Thousand and One Nights http://ar.wikisource.org/wiki/%D8%A3%D9%84%D9%81_%D9%84%D9%8A%D9%84%D8%A9_%D9%88%D9%84%D9%8A%D9%84%D8%A9/%D8%A7%D9%84%D8%AC%D8%B2%D8%A1_%D8%A7%D9%84%D8%A3%D9%88%D9%84 which according to all I could find out is in the public domain.

Attachments
Patch (15.04 KB, patch) 2013-02-05 08:35 PST, Dominik Röttsches (drott)	no flags	Details Formatted Diff Diff
Patch (15.04 KB, patch) 2013-02-05 08:37 PST, Dominik Röttsches (drott)	no flags	Details Formatted Diff Diff
Patch, v2 - Skipping. (15.65 KB, patch) 2013-02-05 10:57 PST, Dominik Röttsches (drott)	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Chris Dumez

Comment 1 2013-02-05 08:33:14 PST

do you mean "text" or "test"?

Dominik Röttsches (drott)

Comment 2 2013-02-05 08:35:46 PST

Created attachment 186630 [details] Patch

Dominik Röttsches (drott)

Comment 3 2013-02-05 08:37:09 PST

(In reply to comment #1) > do you mean "text" or "test"? Test, sry.

Dominik Röttsches (drott)

Comment 4 2013-02-05 08:37:50 PST

Created attachment 186631 [details] Patch

Eric Seidel (no email)

Comment 5 2013-02-05 09:42:35 PST

Comment on attachment 186631 [details] Patch So this is going to include the creation of the rendering tree from scratch, is that what you intented?

Dominik Röttsches (drott)

Comment 6 2013-02-05 10:29:16 PST

(In reply to comment #5) > (From update of attachment 186631 [details]) > So this is going to include the creation of the rendering tree from scratch, is that what you intented? Yes, my intention was to get the width measurement of the complex font path measured. As far as I understand, creating the render tree initially does this in a similar way as a reflow.

Ryosuke Niwa

Comment 7 2013-02-05 10:30:49 PST

Comment on attachment 186631 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=186631&action=review > PerformanceTests/ChangeLog:11 > + * Layout/arabic-line-layout.html: Added. Please skip this test by default.

Ryosuke Niwa

Comment 8 2013-02-05 10:31:36 PST

Also, please use CamelCase.

Ryosuke Niwa

Comment 9 2013-02-05 10:32:00 PST

(In reply to comment #8) > Also, please use CamelCase. for the file name.

Dominik Röttsches (drott)

Comment 10 2013-02-05 10:57:46 PST

Created attachment 186660 [details] Patch, v2 - Skipping.

WebKit Review Bot

Comment 11 2013-02-05 11:17:33 PST

Comment on attachment 186660 [details] Patch, v2 - Skipping. Clearing flags on attachment: 186660 Committed r141906: <http://trac.webkit.org/changeset/141906>

WebKit Review Bot

Comment 12 2013-02-05 11:17:37 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.