Bug 108933

Summary: Web Inspector: file selector list jumps as I type or move Up/Down
Product: WebKit Reporter: Pavel Feldman <pfeldman>
Component: Web Inspector (Deprecated)Assignee: Pavel Feldman <pfeldman>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, keishi, loislo, pfeldman, pmuellr, vsevik, web-inspector-bugs, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch vsevik: review+

Pavel Feldman
Reported 2013-02-05 05:27:26 PST
Fix to follow.
Attachments
Patch (6.66 KB, patch)
2013-02-05 05:35 PST, Pavel Feldman 		no flags
DetailsFormatted DiffDiff
Patch (7.76 KB, patch)
2013-02-06 01:35 PST, Pavel Feldman 		vsevik: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Pavel Feldman
Comment 1 2013-02-05 05:35:54 PST
Created attachment 186608 [details] Patch
Build Bot
Comment 2 2013-02-05 07:33:15 PST
Comment on attachment 186608 [details] Patch Attachment 186608 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/16379608
Vsevolod Vlasov
Comment 3 2013-02-06 00:26:02 PST
Comment on attachment 186608 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=186608&action=review > Source/WebCore/inspector/front-end/FilteredItemSelectionDialog.js:288 > + this._updateSelection(this._selectedIndexInFiltered, false); Should we check this._selectedIndexInFiltered for null? > Source/WebCore/inspector/front-end/FilteredItemSelectionDialog.js:301 > + event.consume(); Wouldn't it be better to do event.consume(true) instead? > Source/WebCore/inspector/front-end/FilteredItemSelectionDialog.js:302 > + return; These "return; break;" pairs look really weird. I would move _scheduleFilter call to default section of this switch instead.
Pavel Feldman
Comment 4 2013-02-06 01:35:53 PST
Created attachment 186788 [details] Patch
Pavel Feldman
Comment 5 2013-02-06 02:13:32 PST
Committed r141979: <http://trac.webkit.org/changeset/141979>
Note You need to log in before you can comment on or make changes to this bug.