Bug 108930 – Web Inspector: [Timeline] Show "curtains" when mouse is over CPU bar.

• Component: Web Inspector (Deprecated)
• Status: RESOLVED FIXED

[Eugene Klyuchnikov]

This feature will help developers to focus on events that caused CPU bar.

[Eugene Klyuchnikov]

Created attachment 186603 [details]
Patch

[Pavel Feldman]

A screenshot?

[Eugene Klyuchnikov]

Created attachment 186841 [details]
Screenshot

[Andrey Kosyakov]

Comment on attachment 186603 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=186603&action=review

The CPU bars would be on top of frame bars in frame mode. I'm a bit concerned how this will look when one attempts to hover over frames to get frame stats...

> Source/WebCore/inspector/front-end/Popover.js:74
> +        this._innerShow(view, view.element, anchor, preferredWidth, preferredHeight, null);

drop null

> Source/WebCore/inspector/front-end/Popover.js:160
> +        if ((roomAbove > roomBelow) || (arrowDirection === "bottom")) {

Please add an enum-style class for the direction.

[Vsevolod Vlasov]

Comment on attachment 186603 [details]
Patch

r- per Andrey;s comment

[Eugene Klyuchnikov]

Created attachment 187564 [details]
Patch

[Eugene Klyuchnikov]

Created attachment 189018 [details]
Screenshot: expand hoverable "frame" space.

@caseq: How do you feel about making "CPU" smaller?

[Eugene Klyuchnikov]

Comment on attachment 187564 [details]
Patch

"hover over frames" is addressed in another bug/patch.
PTAL.

[Eugene Klyuchnikov]

Created attachment 190935 [details]
Screenshot

[WebKit Review Bot]

Comment on attachment 187564 [details]
Patch

Clearing flags on attachment: 187564

Committed r144453: <http://trac.webkit.org/changeset/144453>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.