Summary: | [Qt][WK2] Fold QtWebPageFindClient into QQuickWebViewPrivate | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Simon Hausmann <hausmann> | ||||
Component: | New Bugs | Assignee: | Simon Hausmann <hausmann> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | abecsi, benjamin, cmarcelo, jturcotte, menard, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 108471 | ||||||
Attachments: |
|
Description
Simon Hausmann
2013-02-05 00:47:40 PST
Created attachment 186567 [details]
Patch
Comment on attachment 186567 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=186567&action=review > Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp:327 > + { > + WKPageFindClient findClient; > + memset(&findClient, 0, sizeof(WKPageFindClient)); > + findClient.version = kWKPageFindClientCurrentVersion; > + findClient.clientInfo = this; > + findClient.didFindString = didFindString; > + findClient.didFailToFindString = didFailToFindString; > + WKPageSetPageFindClient(toAPI(webPageProxy.get()), &findClient); > + } If the intent is to do so with most C API clients, it would be cleaner move all their initialization in a separate method. We can also do this once we have more of them here. r=me either way. This still needs a sign-off from a WK2 owner. Benjamin, can you help us with this? :) Comment on attachment 186567 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=186567&action=review Okay with me, feel free to land. Isn't that exposing a bit too much in case you want to make QQuickWebView publicly available from C++? > Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp:2082 > + didFindString(page, string, 0, clientInfo); Maybe prefix by QQuickWebViewPrivate:: for clarity? (In reply to comment #4) > (From update of attachment 186567 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=186567&action=review > > Okay with me, feel free to land. Thank you! > Isn't that exposing a bit too much in case you want to make QQuickWebView publicly available from C++? It is becoming less and less likely that we're going to make the QML implementation a public C++ API :) > > Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp:2082 > > + didFindString(page, string, 0, clientInfo); > > Maybe prefix by QQuickWebViewPrivate:: for clarity? Good idea. Committed r142073: <http://trac.webkit.org/changeset/142073> |