Bug 10892
| Summary: | Fix the member variables in HTMLTableElement to be RefPtrs and to update properly across dynamic changes | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Dave Hyatt <hyatt> |
| Component: | Tables | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED CONFIGURATION CHANGED | ||
| Severity: | Normal | CC: | ahmad.saleem792, ap, bfulgham, ddkilzer, rniwa |
| Priority: | P2 | ||
| Version: | 420+ | ||
| Hardware: | Mac | ||
| OS: | OS X 10.4 | ||
Dave Hyatt
The head, body, foot and caption members of HTMLTableElement should be RefPtrs. They also need to update properly in response to dynamic DOM changes (they are not doing that correctly at all right now).
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Ahmad Saleem
Table Head
https://github.com/WebKit/WebKit/blob/147df77f6bb805a2c35456b30b5bbb8f794b043c/Source/WebCore/html/HTMLTableElement.cpp#L81
Table Foot
https://github.com/WebKit/WebKit/blob/147df77f6bb805a2c35456b30b5bbb8f794b043c/Source/WebCore/html/HTMLTableElement.cpp#L108
Table Caption
https://github.com/WebKit/WebKit/blob/147df77f6bb805a2c35456b30b5bbb8f794b043c/Source/WebCore/html/HTMLTableElement.cpp#L68
I think only body is not yet RefPtrs but I might be wrong:
https://github.com/WebKit/WebKit/blob/147df77f6bb805a2c35456b30b5bbb8f794b043c/Source/WebCore/html/HTMLTableElement.cpp#L157
Just wanted to update and also please update accordingly whether it can be "RESOLVED LATER" or it is something already done. Thanks!
Ryosuke Niwa
We don't store these nodes as member variables anymore,