Bug 108904

Summary:

Adds the WebGL Conformance Tests limits folder.

Product:

WebKit

Reporter:

Gregg Tavares <gman>

Component:

WebGL

Assignee:

Gregg Tavares <gman>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, kbr, rniwa, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

94643

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none

Gregg Tavares

Reported 2013-02-04 22:02:20 PST

Adds the WebGL Conformance Tests limits folder.

Attachments
Patch (24.66 KB, patch) 2013-02-04 22:02 PST, Gregg Tavares	no flags	Details Formatted Diff Diff
Patch (25.62 KB, patch) 2013-02-06 18:20 PST, Gregg Tavares	no flags	Details Formatted Diff Diff
Patch (25.61 KB, patch) 2013-02-13 23:59 PST, Gregg Tavares	no flags	Details Formatted Diff Diff
Patch (25.57 KB, patch) 2013-02-14 00:02 PST, Gregg Tavares	no flags	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

Gregg Tavares

Comment 1 2013-02-04 22:02:45 PST

Created attachment 186545 [details] Patch

Build Bot

Comment 2 2013-02-04 22:30:25 PST

Comment on attachment 186545 [details] Patch Attachment 186545 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://queues.webkit.org/results/16377460 New failing tests: webgl/conformance/limits/gl-max-texture-dimensions.html

Build Bot

Comment 3 2013-02-04 23:37:51 PST

Comment on attachment 186545 [details] Patch Attachment 186545 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/16375587 New failing tests: webgl/conformance/limits/gl-max-texture-dimensions.html

Build Bot

Comment 4 2013-02-05 00:07:32 PST

Comment on attachment 186545 [details] Patch Attachment 186545 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/16379472 New failing tests: webgl/conformance/limits/gl-max-texture-dimensions.html

Kenneth Russell

Comment 5 2013-02-05 11:11:20 PST

Comment on attachment 186545 [details] Patch The Mac bots probably have Intel GPUs. I think I've seen webgl/conformance/limits/gl-max-texture-dimensions.html failing locally and that this is a driver bug. Could you add a line in TestExpectations (probably need it for mac, mac-wk2 and chromium-mac) expecting a failure? r=me with that change.

Gregg Tavares

Comment 6 2013-02-06 18:20:05 PST

Created attachment 186970 [details] Patch

Kenneth Russell

Comment 7 2013-02-06 18:53:10 PST

Comment on attachment 186970 [details] Patch Looks good.

WebKit Review Bot

Comment 8 2013-02-07 05:33:06 PST

Comment on attachment 186970 [details] Patch Rejecting attachment 186970 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=gce-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 186970, '--port=chromium-xvfb']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue Last 500 characters of output: limits/gl-max-texture-dimensions.html patching file LayoutTests/webgl/resources/webgl_test_files/conformance/limits/gl-min-attribs.html patching file LayoutTests/webgl/resources/webgl_test_files/conformance/limits/gl-min-textures.html patching file LayoutTests/webgl/resources/webgl_test_files/conformance/limits/gl-min-uniforms.html Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', '--force', '--reviewer', 'Kenneth Russell']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue Full output: http://queues.webkit.org/results/16426144

Gregg Tavares

Comment 9 2013-02-13 23:59:31 PST

Created attachment 188270 [details] Patch

Gregg Tavares

Comment 10 2013-02-14 00:02:18 PST

Created attachment 188271 [details] Patch

Gregg Tavares

Comment 11 2013-02-14 00:02:51 PST

Committed r142856: <http://trac.webkit.org/changeset/142856>

Eric Seidel (no email)

Comment 12 2013-03-01 02:53:39 PST

Comment on attachment 188271 [details] Patch Cleared review? from attachment 188271 [details] so that this bug does not appear in http://webkit.org/pending-review. If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again).

Note You need to log in before you can comment on or make changes to this bug.