Bug 108871

Summary: Move HTMLShadowElement code behind SHADOW_DOM flag.
Product: WebKit Reporter: Changhun Kang <chkang514>
Component: DOMAssignee: Nobody <webkit-unassigned>
Status: RESOLVED WONTFIX    
Severity: Normal CC: abarth, dglazkov, dominicc, esprehn, koivisto, mifenton, morrita, ojan.autocc, rniwa, tkent, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch chkang514: review-, chkang514: commit-queue-

Changhun Kang
Reported 2013-02-04 15:35:12 PST
According to Bug 103339(https://bugs.webkit.org/show_bug.cgi?id=103339), I hide #include "HTMLShadowElement.h".
Attachments
Patch (2.11 KB, patch)
2013-02-04 15:41 PST, Changhun Kang 		chkang514: review-
chkang514: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Changhun Kang
Comment 1 2013-02-04 15:41:35 PST
Created attachment 186481 [details] Patch
Kent Tamura
Comment 2 2013-02-04 17:15:37 PST
Comment on attachment 186481 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=186481&action=review > Source/WebCore/dom/NodeRenderingContext.cpp:38 > +#if ENABLE(SHADOW_DOM) > #include "HTMLShadowElement.h" > +#endif Why do you want to do this? I don't think we need to do it because the content of HTMLShadowElement.h is already wrapped with ENABEL(SHADOW_DOM).
Changhun Kang
Comment 3 2013-02-07 02:20:02 PST
(In reply to comment #2) > (From update of attachment 186481 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=186481&action=review > > > Source/WebCore/dom/NodeRenderingContext.cpp:38 > > +#if ENABLE(SHADOW_DOM) > > #include "HTMLShadowElement.h" > > +#endif > > Why do you want to do this? > I don't think we need to do it because the content of HTMLShadowElement.h is already wrapped with ENABEL(SHADOW_DOM). I agree with your opinion. Thanks for your advice. I close this bug.
Ryosuke Niwa
Comment 4 2020-08-18 10:43:08 PDT
This code is gone.
Note You need to log in before you can comment on or make changes to this bug.