Summary: | Move HTMLShadowElement code behind SHADOW_DOM flag. | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Changhun Kang <chkang514> | ||||
Component: | DOM | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED WONTFIX | ||||||
Severity: | Normal | CC: | abarth, dglazkov, dominicc, esprehn, koivisto, mifenton, morrita, ojan.autocc, rniwa, tkent, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Changhun Kang
2013-02-04 15:35:12 PST
Created attachment 186481 [details]
Patch
Comment on attachment 186481 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=186481&action=review > Source/WebCore/dom/NodeRenderingContext.cpp:38 > +#if ENABLE(SHADOW_DOM) > #include "HTMLShadowElement.h" > +#endif Why do you want to do this? I don't think we need to do it because the content of HTMLShadowElement.h is already wrapped with ENABEL(SHADOW_DOM). (In reply to comment #2) > (From update of attachment 186481 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=186481&action=review > > > Source/WebCore/dom/NodeRenderingContext.cpp:38 > > +#if ENABLE(SHADOW_DOM) > > #include "HTMLShadowElement.h" > > +#endif > > Why do you want to do this? > I don't think we need to do it because the content of HTMLShadowElement.h is already wrapped with ENABEL(SHADOW_DOM). I agree with your opinion. Thanks for your advice. I close this bug. This code is gone. |