Bug 108856

Summary:

Allow TextTracks to be marked as closed captions

Product:

WebKit

Reporter:

Dean Jackson <dino>

Component:

Media

Assignee:

Dean Jackson <dino>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

eric.carlson, ojan.autocc, webkit-bug-importer, webkit.review.bot

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	darin: review+

Description Dean Jackson 2013-02-04 13:56:32 PST

While this isn't exposed directly in markup, some platform media frameworks can provide indication that a caption track is a closed caption. Expose such a flag on TextTrack and platforms can show a different UI if they want to.

Comment 1 Radar WebKit Bug Importer 2013-02-04 13:56:53 PST

<rdar://problem/13147063>

Comment 2 Dean Jackson 2013-02-04 14:00:28 PST

Created attachment 186455 [details]
Patch

Comment 3 Darin Adler 2013-02-04 14:14:44 PST

Comment on attachment 186455 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=186455&action=review

A little strange to land just the patch that adds the data, but OK if you will follow up soon.

> Source/WebCore/html/track/TextTrack.cpp:110
> +    , m_closedCaption(false)

Should be named m_isClosedCaption.

> Source/WebCore/html/track/TextTrack.h:113
> +    void setIsClosedCaption(bool c) { m_closedCaption = c; }

I’d name the local variable “isClosedCaption” rather than c.

Comment 4 Dean Jackson 2013-02-04 18:03:29 PST

Committed r141840: <http://trac.webkit.org/changeset/141840>