Bug 108849

Summary: Add support for gesture scroll events that do not propagate to enclosing scrollables
Product: WebKit Reporter: Terry Anderson <tdanderson>
Component: UI EventsAssignee: Terry Anderson <tdanderson>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dglazkov, eric, fishd, jamesr, jochen, ojan.autocc, rjkroege, simon.fraser, tkent+wkapi, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 109091    
Bug Blocks: 108719    
Attachments:
Description Flags
Patch
none
Patch
none
Fixed compilation issue after rollout, patch for landing none

Terry Anderson
Reported 2013-02-04 12:40:57 PST
Add support for gesture scroll events that do not propagate to enclosing scrollables. This will be used by the chromium port in https://bugs.webkit.org/show_bug.cgi?id=108719 to ensure that fling gestures scroll only their intended target.
Attachments
Patch (43.45 KB, patch)
2013-02-04 13:05 PST, Terry Anderson 		no flags
DetailsFormatted DiffDiff
Patch (43.68 KB, patch)
2013-02-05 16:09 PST, Terry Anderson 		no flags
DetailsFormatted DiffDiff
Fixed compilation issue after rollout, patch for landing (44.66 KB, patch)
2013-02-06 15:37 PST, Terry Anderson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Terry Anderson
Comment 1 2013-02-04 13:05:21 PST
Created attachment 186443 [details] Patch
WebKit Review Bot
Comment 2 2013-02-04 13:08:28 PST
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Antonio Gomes
Comment 3 2013-02-05 15:02:58 PST
Comment on attachment 186443 [details] Patch I am not sure I like the naming used for the new event type: GestureScrollUpdateNotPropagated. It is the only event type that has a verb at the end. Maybe GestureScrollUpdateWithoutPropagation makes more sense? Rest looks sensible.
Terry Anderson
Comment 4 2013-02-05 16:09:24 PST
Created attachment 186721 [details] Patch
Terry Anderson
Comment 5 2013-02-05 16:10:17 PST
(In reply to comment #4) > Created an attachment (id=186721) [details] > Patch GestureScrollUpdateNotPropagated changed to GestureScrollUpdateWithoutPropagation.
Antonio Gomes
Comment 6 2013-02-06 11:42:50 PST
Comment on attachment 186721 [details] Patch Get someone to sign-off the chromium API bits before committing. r=me
James Robinson
Comment 7 2013-02-06 12:49:57 PST
Comment on attachment 186721 [details] Patch r=me for the chromium bits
WebKit Review Bot
Comment 8 2013-02-06 13:27:56 PST
Comment on attachment 186721 [details] Patch Clearing flags on attachment: 186721 Committed r142025: <http://trac.webkit.org/changeset/142025>
WebKit Review Bot
Comment 9 2013-02-06 13:28:01 PST
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 10 2013-02-06 13:51:50 PST
Re-opened since this is blocked by bug 109091
Terry Anderson
Comment 11 2013-02-06 13:55:52 PST
I rolled this out due to a compile-time error: http://build.webkit.org/builders/Chromium%20Mac%20Release/builds/55141/steps/compile-webkit/logs/stdio Will fix up and re-land.
Terry Anderson
Comment 12 2013-02-06 15:37:29 PST
Created attachment 186936 [details] Fixed compilation issue after rollout, patch for landing
WebKit Review Bot
Comment 13 2013-02-06 17:03:09 PST
Comment on attachment 186936 [details] Fixed compilation issue after rollout, patch for landing Clearing flags on attachment: 186936 Committed r142057: <http://trac.webkit.org/changeset/142057>
WebKit Review Bot
Comment 14 2013-02-06 17:03:16 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.