Summary: | Web Inspector: Test bad options to evaluate and ensure the errors are returned | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | johnjbarton <johnjbarton> | ||||
Component: | Web Inspector (Deprecated) | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED INVALID | ||||||
Severity: | Normal | CC: | apavlov, buildbot, burg, caseq, keishi, loislo, pfeldman, pmuellr, rniwa, vsevik, web-inspector-bugs, yurys | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 106811 | ||||||
Attachments: |
|
Description
johnjbarton
2013-02-04 12:15:42 PST
The bad-option test on the patch for bug 106811 cannot pass without a fix to this bug. Created attachment 186436 [details]
Patch
Comment on attachment 186436 [details] Patch Attachment 186436 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://queues.webkit.org/results/16365456 New failing tests: inspector/extensions/extensions-eval-content-script-bad-option.html Comment on attachment 186436 [details] Patch Attachment 186436 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/16366508 New failing tests: inspector/extensions/extensions-eval-content-script-bad-option.html Comment on attachment 186436 [details] Patch Attachment 186436 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/16366511 New failing tests: inspector/extensions/extensions-eval-content-script-bad-option.html Comment on attachment 186436 [details] Patch I don't think we should invoke the callback wrapper passing it the text error message. Besides, returning value from the message handler already results in dispatching the error to the client. See also bug 108640. Comment on attachment 186436 [details]
Patch
r- per Andrey's comment.
|