Bug 108818

Summary: [v8] explicit isolate parameter for MakeWeak calls
Product: WebKit Reporter: Dan Carney <dcarney>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, haraken, japhet, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Dan Carney
Reported 2013-02-04 05:22:38 PST
[v8] explicit isolate parameter for MakeWeak calls
Attachments
Patch (25.18 KB, patch)
2013-02-04 05:24 PST, Dan Carney 		no flags
DetailsFormatted DiffDiff
Patch (25.19 KB, patch)
2013-02-04 05:49 PST, Dan Carney 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Dan Carney
Comment 1 2013-02-04 05:24:40 PST
Created attachment 186357 [details] Patch
Kentaro Hara
Comment 2 2013-02-04 05:40:41 PST
Comment on attachment 186357 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=186357&action=review > Source/WebCore/bindings/v8/DOMDataStore.cpp:43 > + , m_wrapperMap(v8::Isolate::GetCurrent()) // TODO Don't call GetCurrent twice. TODO =>　FIXME > Source/WebCore/bindings/v8/DOMWrapperMap.h:108 > + v8::NearDeathCallback m_callback; NearDeathCallback is a good name!
Kentaro Hara
Comment 3 2013-02-04 05:41:06 PST
View in context: https://bugs.webkit.org/attachment.cgi?id=186357&action=review > Source/WebCore/bindings/v8/DOMDataStore.cpp:43 > + , m_wrapperMap(v8::Isolate::GetCurrent()) // TODO Don't call GetCurrent twice. TODO =>　FIXME > Source/WebCore/bindings/v8/DOMWrapperMap.h:108 > + v8::NearDeathCallback m_callback; NearDeathCallback is a good name!
Dan Carney
Comment 4 2013-02-04 05:49:25 PST
Created attachment 186360 [details] Patch
Dan Carney
Comment 5 2013-02-04 05:49:56 PST
Comment on attachment 186360 [details] Patch addressed TODO => FIXME issue
WebKit Review Bot
Comment 6 2013-02-04 07:58:28 PST
Comment on attachment 186360 [details] Patch Clearing flags on attachment: 186360 Committed r141771: <http://trac.webkit.org/changeset/141771>
WebKit Review Bot
Comment 7 2013-02-04 07:58:31 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.