Bug 108818

Summary: [v8] explicit isolate parameter for MakeWeak calls
Product: WebKit Reporter: Dan Carney <dcarney>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, haraken, japhet, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Dan Carney 2013-02-04 05:22:38 PST
[v8] explicit isolate parameter for MakeWeak calls
Comment 1 Dan Carney 2013-02-04 05:24:40 PST
Created attachment 186357 [details]
Patch
Comment 2 Kentaro Hara 2013-02-04 05:40:41 PST
Comment on attachment 186357 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=186357&action=review

> Source/WebCore/bindings/v8/DOMDataStore.cpp:43
> +    , m_wrapperMap(v8::Isolate::GetCurrent()) // TODO Don't call GetCurrent twice.

TODO => FIXME

> Source/WebCore/bindings/v8/DOMWrapperMap.h:108
> +    v8::NearDeathCallback m_callback;

NearDeathCallback is a good name!
Comment 3 Kentaro Hara 2013-02-04 05:41:06 PST
View in context: https://bugs.webkit.org/attachment.cgi?id=186357&action=review

> Source/WebCore/bindings/v8/DOMDataStore.cpp:43
> +    , m_wrapperMap(v8::Isolate::GetCurrent()) // TODO Don't call GetCurrent twice.

TODO => FIXME

> Source/WebCore/bindings/v8/DOMWrapperMap.h:108
> +    v8::NearDeathCallback m_callback;

NearDeathCallback is a good name!
Comment 4 Dan Carney 2013-02-04 05:49:25 PST
Created attachment 186360 [details]
Patch
Comment 5 Dan Carney 2013-02-04 05:49:56 PST
Comment on attachment 186360 [details]
Patch

addressed TODO => FIXME issue
Comment 6 WebKit Review Bot 2013-02-04 07:58:28 PST
Comment on attachment 186360 [details]
Patch

Clearing flags on attachment: 186360

Committed r141771: <http://trac.webkit.org/changeset/141771>
Comment 7 WebKit Review Bot 2013-02-04 07:58:31 PST
All reviewed patches have been landed.  Closing bug.