Summary: | [v8] explicit isolate parameter for MakeWeak calls | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Dan Carney <dcarney> | ||||||
Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | abarth, haraken, japhet, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Dan Carney
2013-02-04 05:22:38 PST
Created attachment 186357 [details]
Patch
Comment on attachment 186357 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=186357&action=review > Source/WebCore/bindings/v8/DOMDataStore.cpp:43 > + , m_wrapperMap(v8::Isolate::GetCurrent()) // TODO Don't call GetCurrent twice. TODO => FIXME > Source/WebCore/bindings/v8/DOMWrapperMap.h:108 > + v8::NearDeathCallback m_callback; NearDeathCallback is a good name! View in context: https://bugs.webkit.org/attachment.cgi?id=186357&action=review > Source/WebCore/bindings/v8/DOMDataStore.cpp:43 > + , m_wrapperMap(v8::Isolate::GetCurrent()) // TODO Don't call GetCurrent twice. TODO => FIXME > Source/WebCore/bindings/v8/DOMWrapperMap.h:108 > + v8::NearDeathCallback m_callback; NearDeathCallback is a good name! Created attachment 186360 [details]
Patch
Comment on attachment 186360 [details]
Patch
addressed TODO => FIXME issue
Comment on attachment 186360 [details] Patch Clearing flags on attachment: 186360 Committed r141771: <http://trac.webkit.org/changeset/141771> All reviewed patches have been landed. Closing bug. |